Sync eng/common directory with azure-sdk-tools for PR 16356#10149
Merged
Conversation
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Adds an Azure Pipelines step template to standardize authentication against an Azure DevOps Python package feed, with optional support for Twine, pip, and uv.
Changes:
- Introduces a reusable pipeline template for selecting the appropriate DevOps feed (public vs internal PR feed).
- Adds conditional TwineAuthenticate and PipAuthenticate steps based on parameters.
- Configures uv to use the authenticated pip index URL and sets a Python install mirror.
Comment on lines
+35
to
+40
| if ($env:PIP_INDEX_URL) { | ||
| Write-Host "Found pip index URL: $($env:PIP_INDEX_URL)" | ||
| # UV_DEFAULT_INDEX is the canonical replacement for the deprecated UV_INDEX_URL (uv 0.4.23+). | ||
| # PIP_INDEX_URL is set by PipAuthenticate@1 and contains embedded credentials, which uv | ||
| # will use for Basic auth against the ADO feed (and its PyPI upstream) per astral-sh/uv#12651. | ||
| Write-Host "##vso[task.setvariable variable=UV_DEFAULT_INDEX]$($env:PIP_INDEX_URL)" |
Comment on lines
+40
to
+42
| Write-Host "##vso[task.setvariable variable=UV_DEFAULT_INDEX]$($env:PIP_INDEX_URL)" | ||
| # Disable keyring so uv uses the URL-embedded credentials directly. | ||
| Write-Host "##vso[task.setvariable variable=UV_KEYRING_PROVIDER]disabled" |
Comment on lines
+43
to
+45
| } else { | ||
| Write-Host "##[warning]PIP_INDEX_URL not set - uv will fall back to public PyPI." | ||
| } |
chidozieononiwu
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16356 See eng/common workflow