Skip to content

Fix issues from CI of js-sdk-release-tools #39267

Open
skywing918 wants to merge 6 commits into
mainfrom
fixCI
Open

Fix issues from CI of js-sdk-release-tools #39267
skywing918 wants to merge 6 commits into
mainfrom
fixCI

Conversation

@skywing918

@skywing918 skywing918 commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes #39266

ci job: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6557932&view=results
publish job:https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6557843&view=results

This pull request updates the Azure JS SDK release tools pipeline to improve CI/CD integration, enhance documentation, and update npm registry configuration. The main changes include refactoring the pipeline to use a shared template, switching npm registry endpoints, and making several documentation formatting improvements.

Pipeline and CI/CD Improvements:

  • Refactored the ci.yml pipeline to use the shared /eng/pipelines/templates/stages/1es-redirect.yml template, improving maintainability and aligning with organization-wide standards. This includes clearer stage/job structure, updated Node.js installation, and conditional publish stage for internal manual builds.
  • Added a step to create an authenticated .npmrc file for secure npm operations in the pipeline.

NPM Registry Configuration:

  • Updated .npmrc files in both the root and typescript-codegen-breaking-change-detector package to use the Azure DevOps npm registry instead of the public npmjs registry, ensuring packages are pulled from the correct internal source. [1] [2]

Documentation Formatting and Clarity:

  • Improved markdown table formatting in automation-pipeline.md for better readability and consistency. This includes aligning columns and updating code links in several process step tables. [1] [2] [3] [4] [5] [6]

Changelog Cleanup:

  • Removed an unnecessary trailing blank line from a test changelog file for tidiness.

Kyle Zhang added 6 commits July 13, 2026 18:37
Update CI configuration to use PublishPipelineArtifact task with cond…
8132f80 
…ition
Add test cases directory to .prettierignore
055f2ca
Fix path in .prettierignore for test cases directory
6c7a5c2
Remove test cases directory from .prettierignore and update package.j…
bd5f5c6 
…son formatting
refactor: standardize string quotes and formatting across utility files
79b0544 
- Changed single quotes to double quotes in multiple files for consistency.
- Updated function signatures to include trailing commas for better readability.
- Reformatted code blocks for improved clarity and adherence to style guidelines.
- Ensured consistent use of semicolons and spacing throughout the codebase.
refactor: restructure CI pipeline for improved build and publish steps
cd63456
Copilot AI review requested due to automatic review settings July 14, 2026 06:47
Copilot AI reviewed Jul 14, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the standalone JS SDK release tools CI to work in 1ES environments and use the Azure DevOps npm feed.

Changes:

  • Migrates CI to the 1ES template with authenticated npm ci, artifact publishing, and manual release support.
  • Commits a deterministic lockfile and makes registry-dependent tests feed-aware.
  • Removes the problematic fixture Prettier configuration and reformats sources, tests, fixtures, and documentation.

Reviewed changes

Copilot reviewed 117 out of 140 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.gitignore Allows the release-tools lockfile.
eng/tools/js-sdk-release-tools-src/.npmrc Uses the Azure DevOps feed.
eng/tools/js-sdk-release-tools-src/ci.yml Migrates CI to 1ES and npm ci.
eng/tools/js-sdk-release-tools-src/docs/automation-pipeline.md Formats documentation tables.
eng/tools/js-sdk-release-tools-src/package-lock.json Adds deterministic dependency resolution.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/.npmrc Uses the Azure DevOps feed.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/docs/azure-rest-level-client-breaking-change-rules.md Formatting cleanup.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/misc/test-cases/rest-level-client-to-rest-level-client/baseline-package/review/arm-servicefabric.api.md Formats API fixture.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/misc/test-cases/rest-level-client-to-rest-level-client/current-package/CHANGELOG.md Formats changelog fixture.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/misc/test-cases/rest-level-client-to-rest-level-client/current-package/review/arm-servicefabric.api.md Formats API fixture.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/src/azure/common/rules/ignore-inline-declarations-in-operation-group.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/src/azure/common/types.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/src/azure/detect-breaking-changes.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/src/azure/diff/DeclarationDifferenceDetector.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/src/azure/patch/patch-detection.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/src/azure/utils/azure-rule-utils.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/src/common/models/rules/rule-descriptions.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/src/common/models/rules/rule-ids.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/src/index.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/src/logging/logger.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/src/tests/patch-detection-class.test.ts Formats tests.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/src/tests/patch-detection-function.test.ts Formats tests.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/src/tests/patch-detection-interface.test.ts Formats tests.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/src/tests/patch-detection-routes.test.ts Formats tests.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/src/tests/patch-detection-type.test.ts Formats tests.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/src/tests/rest-level-client-rule.test.ts Formats tests.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/src/tests/utils.ts Formats test utilities.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/src/utils/ast-utils.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/src/utils/common-utils.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/tsconfig.json Formats configuration.
eng/tools/js-sdk-release-tools-src/packages/typescript-codegen-breaking-change-detector/vitest.config.ts Formats test configuration.
eng/tools/js-sdk-release-tools-src/src/autoGenerateInPipeline.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/changelog/RestLevelClientChangelogPostProcessor.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/changelog/changelogGenerator.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/changelog/extractMetaData.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/changelog/v2/ChangelogGenerator.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/changelog/v2/DifferenceDetector.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/changelogToolCli.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/common/changelog/automaticGenerateChangeLogAndBumpVersion.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/common/changelog/modifyChangelogFileAndBumpVersion.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/common/ciYamlUtils.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/common/codeOwnersAndIgnoreLink/codeOwnersAndIgnoreLinkGenerator.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/common/devToolUtils.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/common/interfaces.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/common/npmUtils.ts Adds an optional registry override.
eng/tools/js-sdk-release-tools-src/src/common/packageResultUtils.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/common/rushUtils.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/common/types.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/common/utils.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/generateChangelogCli.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/generateCiYamlCli.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/hlc/apiVersion/apiVersionTypeExtractor.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/hlc/generateMgmt.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/hlc/utils/changeReadmeMd.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/hlc/utils/getReleaseTool.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/hlcCodeGenCli.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/llc/apiVersion/apiVersionTypeExtractor.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/llc/generateRLCInPipeline/generateRLCInPipeline.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/llc/generateRLCInTerminal/generateRLCInTerminal.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/llc/utils/generateChangelog.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/llc/utils/generateExtraFiles.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/llc/utils/generateSampleReadmeMd.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/llc/utils/prepareCommandToInstallDependenciesForTypeSpecProject.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/llc/utils/updateTypeSpecProjectYamlFile.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/llc/utils/utils.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/mlc/apiVersion/apiVersionTypeExtractor.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/mlc/clientGenerator/modularClientPackageGenerator.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/mlc/clientGenerator/utils/typeSpecUtils.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/rlcCodegenCli.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/test/apiVersion/apiVersionExtractor.test.ts Formats tests.
eng/tools/js-sdk-release-tools-src/src/test/apiVersion/testCases/mlc-model-only/package.json Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/apiVersion/testCases/new-context/src/api/openAIContext.ts Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/apiVersion/testCases/rlc-client/src/newClient.ts Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/apiVersion/testCases/rlc-context/src/openAIContext.ts Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/apiVersion/testCases/rlc-model-only/package.json Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/apiVersion/testCases/rlc-source-from-readme/package.json Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/apiVersion/testCases/rlc-source-from-readme/src1/parameters.ts Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/apiVersion/testCases/rlc-source-from-readme/swagger/README.md Closes and formats YAML block.
eng/tools/js-sdk-release-tools-src/src/test/apiVersion/testCases/rlc-source-from-src-streaming/package.json Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/apiVersion/testCases/rlc-source-from-src-streaming/src/parameters.ts Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/apiVersion/testCases/rlc-source-from-src/package.json Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/apiVersion/testCases/rlc-source-from-src/src/parameters.ts Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/changelog/automaticGenerateChangeLogAndBumpVersion.test.ts Formats tests.
eng/tools/js-sdk-release-tools-src/src/test/changelog/changelogGenerator.test.ts Formats tests.
eng/tools/js-sdk-release-tools-src/src/test/changelog/modifyChangelogFileAndBumpVersion.test.ts Formats tests.
eng/tools/js-sdk-release-tools-src/src/test/changelog/testCases/hlc-first-release/package.json Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/changelog/testCases/hlc-first-release/src/models/parameters.ts Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/changelog/testCases/hlc-first-release/src/testClient.ts Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/changelog/testCases/modular-first-release/package.json Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/changelog/testCases/modular-first-release/src/api/testContext.ts Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/changelog/testCases/operationGroups.1.new.modular.api.md Formats API fixture.
eng/tools/js-sdk-release-tools-src/src/test/changelog/testCases/operationGroups.1.old.hlc.api.md Formats API fixture.
eng/tools/js-sdk-release-tools-src/src/test/changelog/testCases/operationGroups.2.new.hlc.api.md Formats API fixture.
eng/tools/js-sdk-release-tools-src/src/test/changelog/testCases/operationGroups.2.old.hlc.api.md Formats API fixture.
eng/tools/js-sdk-release-tools-src/src/test/changelog/testCases/operationGroups.3.new.modular.api.md Formats API fixture.
eng/tools/js-sdk-release-tools-src/src/test/changelog/testCases/operationGroups.3.old.modular.api.md Formats API fixture.
eng/tools/js-sdk-release-tools-src/src/test/changelog/testCases/operationGroups.4.new.hlc.api.md Formats API fixture.
eng/tools/js-sdk-release-tools-src/src/test/changelog/testCases/operationGroups.4.old.hlc.api.md Formats API fixture.
eng/tools/js-sdk-release-tools-src/src/test/changelog/testCases/operationGroups.5.new.modular.api.md Formats API fixture.
eng/tools/js-sdk-release-tools-src/src/test/changelog/testCases/operationGroups.5.old.hlc.api.md Formats API fixture.
eng/tools/js-sdk-release-tools-src/src/test/changelog/testCases/operationGroups.6.new.modular.api.md Formats API fixture.
eng/tools/js-sdk-release-tools-src/src/test/changelog/testCases/operationGroups.6.old.hlc.api.md Formats API fixture.
eng/tools/js-sdk-release-tools-src/src/test/changelog/testCases/patch.1.new.rlc.api.md Formats API fixture.
eng/tools/js-sdk-release-tools-src/src/test/changelog/testCases/patch.1.old.rlc.api.md Formats API fixture.
eng/tools/js-sdk-release-tools-src/src/test/changelog/testCases/rlc-first-release/package.json Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/changelog/testCases/rlc-first-release/src/testClient.ts Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/command/runCommand.test.ts Formats tests.
eng/tools/js-sdk-release-tools-src/src/test/common/ciYamlUtils.test.ts Formats tests.
eng/tools/js-sdk-release-tools-src/src/test/common/codeownersAndignorelink/generateCodeOwnersAndIgnoreLink.test.ts Formats tests.
eng/tools/js-sdk-release-tools-src/src/test/common/config/myConfig.yaml Formats YAML fixture.
eng/tools/js-sdk-release-tools-src/src/test/common/utils.test.ts Formats tests.
eng/tools/js-sdk-release-tools-src/src/test/hlc/vulnerability.test.ts Formats tests.
eng/tools/js-sdk-release-tools-src/src/test/npm/npm.test.ts Uses the configured registry in npm-view tests.
eng/tools/js-sdk-release-tools-src/src/test/npm/testCases/package.json Removes unresolved nested Prettier configuration.
eng/tools/js-sdk-release-tools-src/src/test/packageVersion/changeClientFile.test.ts Formats tests.
eng/tools/js-sdk-release-tools-src/src/test/packageVersion/testCases/hlc-context/package.json Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/packageVersion/testCases/hlc-context/src/models/parameters.ts Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/packageVersion/testCases/hlc-context/src/testClient.ts Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/packageVersion/testCases/modular-context/package.json Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/packageVersion/testCases/modular-context/src/api/testContext.ts Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/packageVersion/testCases/rlc-context/package.json Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/packageVersion/testCases/rlc-context/src/testClient.ts Formats fixture.
eng/tools/js-sdk-release-tools-src/src/test/pipeline/sdkGeneration.test.ts Formats tests.
eng/tools/js-sdk-release-tools-src/src/test/utils/utils.ts Formats test utilities.
eng/tools/js-sdk-release-tools-src/src/test/version/version.test.ts Formats tests.
eng/tools/js-sdk-release-tools-src/src/updateBumpVersionCli.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/utils/addApiViewInfo.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/utils/backupNodeModules.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/utils/changeCiYaml.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/utils/changeConfigOfTestAndSample.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/utils/changeRushJson.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/utils/generateInputUtils.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/utils/getOutputPackageInfo.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/utils/git.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/utils/logger.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/utils/version.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/xlc/apiVersion/apiVersionTypeExtractor.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/xlc/apiVersion/utils.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/src/xlc/codeUpdate/updateUserAgent.ts Prettier formatting.
eng/tools/js-sdk-release-tools-src/vitest.config.ts Formats test configuration.

JialinHuang803
JialinHuang803 reviewed Jul 14, 2026
View reviewed changes
Comment thread eng/tools/js-sdk-release-tools-src/ci.yml

@JialinHuang803 JialinHuang803 Jul 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. But I may want @jeremymeng to help take a look at the ci.yml as I am not an expert on it.

@jeremymeng

jeremymeng commented Jul 14, 2026

Copy link
Copy Markdown
Member

Looks good overall. Is it possible to split this into two PRs, one for CI changes and another for formatting changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JialinHuang803 JialinHuang803 JialinHuang803 approved these changes
Copilot code review Copilot Copilot left review comments
@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner
@MaryGao MaryGao Awaiting requested review from MaryGao MaryGao is a code owner
@jeremymeng jeremymeng Awaiting requested review from jeremymeng jeremymeng is a code owner
@xirzec xirzec Awaiting requested review from xirzec xirzec is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[js-sdk-release-tools-src] Fix CI pipeline failures after migration to azure-sdk-for-js

4 participants

@skywing918 @jeremymeng @JialinHuang803