Skip to content

Fix custom agent guideline links in Copilot App#39264

Open
xirzec wants to merge 1 commit into
mainfrom
xirzec-fix-agent-guideline-links
Open

Fix custom agent guideline links in Copilot App#39264
xirzec wants to merge 1 commit into
mainfrom
xirzec-fix-agent-guideline-links

Conversation

@xirzec

@xirzec xirzec commented Jul 13, 2026

Copy link
Copy Markdown
Member

Packages impacted by this PR

N/A — this changes repository-level Copilot agent configuration.

Issues associated with this PR

N/A.

Describe the problem that is addressed by this PR

Custom agent profiles linked their detailed guidelines with paths relative to .github/agents, such as ../prompts/architecture-review-guidelines.md. The Copilot App resolves agent-profile links from the repository root, so those links were interpreted as prompts/... and the guidelines failed to load.

This PR uses repository-root-relative .github/prompts/... targets in every affected agent profile and documents that resolver behavior.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

The prompt files could be moved or duplicated under a root-level prompts/ directory, but that would split or relocate the existing canonical guidance. Repository-root-relative links preserve the current layout and match the Copilot App resolver.

Are there test cases added in this PR? (If not, why?)

No automated tests were added because this is Markdown-based agent configuration. All nine links were checked against existing repository files, and a newly launched Archie agent successfully loaded .github/prompts/architecture-review-guidelines.md.

Provide a list of related PRs (if any)

N/A.

Command used to generate this PR:**(Applicable only to SDK release request PRs)

N/A.

Checklists

  • N/A — no SDK package is impacted.
  • No SDK Generator fixes are needed.
  • No changelog is necessary.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 89ca6722-d3a1-4ffc-92a7-ab2ccf8314e6
@xirzec xirzec marked this pull request as ready for review July 13, 2026 22:52
Copilot AI review requested due to automatic review settings July 13, 2026 22:52
@xirzec xirzec requested review from a team, jeremymeng and maorleger as code owners July 13, 2026 22:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates custom agent guideline links so Copilot resolves them from the repository root.

Changes:

  • Corrects nine guideline links across eight agent profiles.
  • Documents repository-root-relative link behavior.
Show a summary per file
File Description
documentation/reviewer-agents.md Documents link resolution behavior.
.github/agents/tester.agent.md Fixes test guidelines link.
.github/agents/sentinel.agent.md Fixes security guidelines link.
.github/agents/scribe.agent.md Fixes documentation guidelines link.
.github/agents/mgmt-review.agent.md Fixes management review link.
.github/agents/mgmt-breaking-change-analysis.agent.md Fixes analysis and pattern links.
.github/agents/dexter.agent.md Fixes dependency guidelines link.
.github/agents/dash.agent.md Fixes performance guidelines link.
.github/agents/archie.agent.md Fixes architecture guidelines link.

Review details

  • Files reviewed: 9/9 changed files
  • Comments generated: 0
  • Review effort level: Medium

@xirzec

xirzec commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

Filed a bug upstream against the CLI since repo-relative links break non-GitHub tooling: github/copilot-cli#4122

# Archie — Architecture Review Agent

Follow the full guidelines in [architecture-review-guidelines.md](../prompts/architecture-review-guidelines.md).
Follow the full guidelines in [architecture-review-guidelines.md](.github/prompts/architecture-review-guidelines.md).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Azure/azure-sdk-for-js/tree/main/.github - Looking at the structure, the previous links are correct, if it has to be relative to the agent file.

@KarishmaGhiya KarishmaGhiya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Azure/azure-sdk-for-js/tree/main/.github - Looking at the structure, the previous links are correct, if it has to be relative to the agent file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants