[dev-tool] Log real tsc failure detail instead of [object Object]#39240
Open
jeremymeng wants to merge 3 commits into
Open
[dev-tool] Log real tsc failure detail instead of [object Object]#39240jeremymeng wants to merge 3 commits into
jeremymeng wants to merge 3 commits into
Conversation
runTypeScript in build-test.ts logged the whole SpawnSyncReturns object on failure, rendering as a useless [object Object]. Since tsc runs with stdio: inherit its diagnostics are already in the log, so log the exit status/signal (and handle the spawn-error case) instead of the object. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
dev-tool
Co-authored-by: jeremymeng <7583839+jeremymeng@users.noreply.github.com>
Fixes the check-format CI failure on the previous commit. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runTypeScriptincommon/tools/dev-tool/src/commands/run/build-test.tslogged the wholeSpawnSyncReturnsobject on failure vialog.error(..., res), which rendered uselessly as[object Object].Fix
Since
tscruns withstdio: "inherit", its diagnostics are already printed to the log. So instead of dumping the object, the failure branch now logs the actual exit code or signal. It also handles the spawn-error case (res.error) — e.g. whentsccan't be spawned,status/signalarenullso the previous check missed it entirely.Verification
From
common/tools/dev-tool,npx tsc -p . --noEmitpasses (exit code 0).Small standalone follow-up to the dev-tool logging improvements in #39238.