[EngSys] add typescript v7 dev dependency#39225
Open
jeremymeng wants to merge 10 commits into
Open
Conversation
and use the `"typescript": "npm:@typescript/typescript6@^6.0.2"` alias side-by-side for packages that need TS compiler api
github-actions
Bot
added
dev-tool
Contributor
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
Pull request overview
This PR updates the repo’s TypeScript toolchain setup to support side-by-side TypeScript 6 (via the @typescript/typescript6 package alias) and TypeScript 7 (via an additional typescript-7 alias), and adds pnpm configuration to accommodate the new TS7 platform packages.
Changes:
- Switch several packages’
typescriptdependency tonpm:@typescript/typescript6@^6.0.2to keep using the TS6 compiler API. - Add a
typescript-7alias (npm:typescript@^7.0.2) in select tool packages. - Add
minimumReleaseAgeExcludeentries inpnpm-workspace.yamlfor TypeScript 7 and its platform-specific packages.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/eventgrid/eventgrid-systemevents/package.json | Switches typescript to the @typescript/typescript6 alias for TS6 compiler API usage. |
| pnpm-workspace.yaml | Adds minimumReleaseAgeExclude entries related to TypeScript 7 packages. |
| common/tools/warp/package.json | Switches typescript to TS6 alias and adds typescript-7 alias. |
| common/tools/eslint-plugin-azure-sdk/package.json | Switches typescript dependency to TS6 alias. |
| common/tools/dev-tool/package.json | Switches typescript to TS6 alias and adds typescript-7 alias. |
Files excluded by content exclusion policy (1)
- pnpm-lock.yaml
Comment on lines
+85
to
+106
| minimumReleaseAgeExclude: | ||
| - '@typescript/typescript-aix-ppc64@7.0.2' | ||
| - '@typescript/typescript-darwin-arm64@7.0.2' | ||
| - '@typescript/typescript-darwin-x64@7.0.2' | ||
| - '@typescript/typescript-freebsd-arm64@7.0.2' | ||
| - '@typescript/typescript-freebsd-x64@7.0.2' | ||
| - '@typescript/typescript-linux-arm64@7.0.2' | ||
| - '@typescript/typescript-linux-arm@7.0.2' | ||
| - '@typescript/typescript-linux-loong64@7.0.2' | ||
| - '@typescript/typescript-linux-mips64el@7.0.2' | ||
| - '@typescript/typescript-linux-ppc64@7.0.2' | ||
| - '@typescript/typescript-linux-riscv64@7.0.2' | ||
| - '@typescript/typescript-linux-s390x@7.0.2' | ||
| - '@typescript/typescript-linux-x64@7.0.2' | ||
| - '@typescript/typescript-netbsd-arm64@7.0.2' | ||
| - '@typescript/typescript-netbsd-x64@7.0.2' | ||
| - '@typescript/typescript-openbsd-arm64@7.0.2' | ||
| - '@typescript/typescript-openbsd-x64@7.0.2' | ||
| - '@typescript/typescript-sunos-x64@7.0.2' | ||
| - '@typescript/typescript-win32-arm64@7.0.2' | ||
| - '@typescript/typescript-win32-x64@7.0.2' | ||
| - typescript@7.0.2 |
need v6 for typescript-eslint
Align azureMatchers vitest augmentation with vitest's own type-parameter shapes: keep Assertion<T> generic, make AsymmetricMatchersContaining non-generic, and drop the generic ExpectStatic<T> augmentation which caused ExpectStatic to inherit toSupportTracing from two non-identical sources (Promise<any> vs Promise<T>) under TypeScript v7. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8bc22921-abae-4c11-8335-fdca58174ef0
Stop using "latest" as version specifier in generated sample package.json for security reason. Resolve the versions used in our repository instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and use the
"typescript": "npm:@typescript/typescript6@^6.0.2"alias side-by-side for packages that need TS compiler api, as suggested by the TypeScript team.