testing empty release test#29864
Open
thomas-temby wants to merge 3 commits into
Open
Conversation
thomas-temby
added
the
Do Not Close 🚫
Contributor
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies the Azure Pipelines release-test definition by removing the Windows and Linux smoke-test job templates, leaving only the job that checks for the latest PowerShell version.
Changes:
- Removed the Win/Linux
util/smoke-test-steps.ymltemplate job entries fromrelease-test.yml. - Kept the
CheckLatestPowerShellVersionjob as the only active job in the pipeline.
Comments suppressed due to low confidence (1)
.azure-pipelines/release-test.yml:55
- Removing all Win/Linux smoke-test template jobs leaves this pipeline only checking the latest PowerShell version, so it no longer performs the release smoke testing implied by
release-test.yml. This significantly reduces release validation coverage; if this was only for an experiment, it should not be merged as-is. Consider restoring the removed smoke-test jobs, or guarding them behind a parameter (defaulting to enabled) so release validation remains intact.
jobs:
- job: CheckLatestPowerShellVersion
displayName: Check for latest PowerShell version
pool:
name: ${{ variables.linuxAgentPoolName }}
steps:
- task: PowerShell@2
displayName: Check for latest PowerShell version
inputs:
pwsh: true
targetType: filePath
filePath: ./tools/TestFx/Live/CheckLatestPowerShellVersion.ps1
|
🤖 Auto-trigger: queued 2 pipeline(s) for commit |
|
🤖 Auto-trigger: queued 2 pipeline(s) for commit |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.azure-pipelines/release-test.yml:55
- This PR appears to remove all Windows/Linux smoke test jobs from the release-test pipeline, leaving only the version-check job. That effectively disables the release validation this pipeline is meant to provide and can allow regressions to ship undetected. If the intent is to temporarily reduce coverage, consider gating smoke tests behind a parameter/variable or commenting them out (like the MacOS entries) rather than deleting them; otherwise, please restore the removed smoke test templates.
jobs:
- job: CheckLatestPowerShellVersion
displayName: Check for latest PowerShell version
pool:
name: ${{ variables.linuxAgentPoolName }}
steps:
- task: PowerShell@2
displayName: Check for latest PowerShell version
inputs:
pwsh: true
targetType: filePath
filePath: ./tools/TestFx/Live/CheckLatestPowerShellVersion.ps1
| @@ -0,0 +1 @@ | |||
| Temp change | |||
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
temp.txt:2
temp.txtis introduced but appears unused (no references found in the repo). Committing a temporary/placeholder file adds noise and can confuse future contributors; please remove it or replace it with a file that’s part of the intended feature/change.
Temp change
More changes
Comment on lines
44
to
46
| jobs: | ||
| - template: util/smoke-test-steps.yml | ||
| parameters: | ||
| name: 'Win_PS5_1_14_SmokeTest' | ||
| agentPoolName: ${{ variables.winAgentPoolName }} | ||
| psVersion: ${{ parameters.win_ps }} | ||
| dotnetVersion: ${{ parameters.dotnet_sdk_8 }} | ||
|
|
||
| - template: util/smoke-test-steps.yml | ||
| parameters: | ||
| name: 'Win_PS7_4_X_SmokeTest' | ||
| agentPoolName: ${{ variables.winAgentPoolName }} | ||
| psVersion: ${{ parameters.ps7_4 }} | ||
| dotnetVersion: ${{ parameters.dotnet_sdk_8 }} | ||
|
|
||
| - template: util/smoke-test-steps.yml | ||
| parameters: | ||
| name: 'Win_PS7_5_X_SmokeTest' | ||
| agentPoolName: ${{ variables.winAgentPoolName }} | ||
| psVersion: ${{ parameters.ps7_5 }} | ||
| dotnetVersion: ${{ parameters.dotnet_sdk_9 }} | ||
|
|
||
| - template: util/smoke-test-steps.yml | ||
| parameters: | ||
| name: 'Win_PS7_6_X_SmokeTest' | ||
| agentPoolName: ${{ variables.winAgentPoolName }} | ||
| psVersion: ${{ parameters.ps7_6 }} | ||
| dotnetVersion: ${{ parameters.dotnet_sdk_10 }} | ||
|
|
||
| - template: util/smoke-test-steps.yml | ||
| parameters: | ||
| name: 'Win_Preview_PS_SmokeTest' | ||
| agentPoolName: ${{ variables.winAgentPoolName }} | ||
| psVersion: ${{ parameters.preview_ps }} | ||
| dotnetVersion: ${{ parameters.dotnet_sdk_9 }} | ||
|
|
||
| - template: util/smoke-test-steps.yml | ||
| parameters: | ||
| name: 'Linux_PS7_4_X_SmokeTest' | ||
| agentPoolName: ${{ variables.linuxAgentPoolName }} | ||
| psVersion: ${{ parameters.ps7_4 }} | ||
| dotnetVersion: ${{ parameters.dotnet_sdk_8 }} | ||
|
|
||
| - template: util/smoke-test-steps.yml | ||
| parameters: | ||
| name: 'Linux_PS7_5_X_SmokeTest' | ||
| agentPoolName: ${{ variables.linuxAgentPoolName }} | ||
| psVersion: ${{ parameters.ps7_5 }} | ||
| dotnetVersion: ${{ parameters.dotnet_sdk_9 }} | ||
|
|
||
| - template: util/smoke-test-steps.yml | ||
| parameters: | ||
| name: 'Linux_PS7_6_X_SmokeTest' | ||
| agentPoolName: ${{ variables.linuxAgentPoolName }} | ||
| psVersion: ${{ parameters.ps7_6 }} | ||
| dotnetVersion: ${{ parameters.dotnet_sdk_10 }} | ||
|
|
||
| - template: util/smoke-test-steps.yml | ||
| parameters: | ||
| name: 'Linux_Preview_PS_SmokeTest' | ||
| agentPoolName: ${{ variables.linuxAgentPoolName }} | ||
| psVersion: ${{ parameters.preview_ps }} | ||
| dotnetVersion: ${{ parameters.dotnet_sdk_9 }} | ||
|
|
||
| - job: CheckLatestPowerShellVersion | ||
| displayName: Check for latest PowerShell version |
|
/azp run azure-powershell - powershell-core |
|
/azp run azure-powershell - windows-powershell |
Contributor
|
Commenter does not have sufficient privileges for PR 29864 in repo Azure/azure-powershell |
1 similar comment
Contributor
|
Commenter does not have sufficient privileges for PR 29864 in repo Azure/azure-powershell |
Contributor
Author
|
/azp run |
Contributor
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
🤖 Auto-trigger: queued 2 pipeline(s) for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.