Add VerifyClientAuthMode support to Application Gateway client auth configuration#29861
Open
paraboys wants to merge 2 commits into
Open
Add VerifyClientAuthMode support to Application Gateway client auth configuration#29861paraboys wants to merge 2 commits into
paraboys wants to merge 2 commits into
Conversation
…configuration conversions
Contributor
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
10 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the Az.Network module’s Application Gateway client authentication configuration model and its AutoMapper conversions to ensure VerifyClientAuthMode survives PowerShell ↔ SDK object transformations.
Changes:
- Added
VerifyClientAuthModetoPSApplicationGatewayClientAuthConfiguration. - Updated AutoMapper mappings in
NetworkResourceManagerProfilefor both CNM → MNM and MNM → CNM conversions. - Added a release note entry describing the fix (with a wording issue noted in review comments).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Network/Network/Models/PSApplicationGatewayClientAuthConfiguration.cs | Adds the missing VerifyClientAuthMode property to the PowerShell model. |
| src/Network/Network/Common/NetworkResourceManagerProfile.cs | Maps VerifyClientAuthMode in both directions to preserve it across conversions. |
| src/Network/Network/ChangeLog.md | Documents the fix in release notes (needs a small correction to accurately describe the prior behavior). |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
| ## Upcoming Release | ||
| * Updated the API version of `Microsoft.HardwareSecurityModules/cloudHsmClusters` to `2025-03-31` for Private Link Common Cmdlets | ||
| * Onboarded `Microsoft.HardwareSecurityModules/paymentHsmClusters` to Private Link Common Cmdlets | ||
| * Fixed an issue where `VerifyClientAuthMode` was not preserved during PowerShell and SDK model conversions for Application Gateway client authentication configuration |
Comment on lines
+1457
to
1460
| .ForMember( | ||
| dest => dest.VerifyClientAuthMode, | ||
| opt => opt.MapFrom(src => src.VerifyClientAuthMode) | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an Application Gateway client authentication configuration issue by preserving
VerifyClientAuthModeduring PowerShell ↔ SDK model conversions.Changes
VerifyClientAuthModetoPSApplicationGatewayClientAuthConfiguration.NetworkResourceManagerProfilefor both PowerShell → SDK and SDK → PowerShell conversions.ChangeLog.mdwith the release note for this fix.Mandatory Checklist
General release
Public preview
Private preview
Engineering build
No need for a release
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/Network/Network/ChangeLog.md.