update and new properties for VNA and VNET#29243
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
…to arjun/vnra-vnet-ps-changes-2025-07-01
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Hi @arjun-d-patel, the ChangeLog file path is src/Network/Network/ChangeLog.md. Please add a line right below |
|
Hi @arjun-d-patel, please resolve the conflict of file src/Network/Network/ChangeLog.md. |
…to arjun/vnra-vnet-ps-changes-2025-07-01 # Conflicts: # src/Network/Network/ChangeLog.md
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Hi @arjun-d-patel, please fix CI errors. |
…kingChange exceptions for BandwidthInGbps type change
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Hi @arjun-d-patel, Please don't manually update files under src/Network/Network.Management.Sdk/Generated. |
… parameter to string type
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Hi @arjun-d-patel, please don't manually update files under src/Network/Network.Management.Sdk/Generated. Or CI will fail. |
…changes-2025-07-01 # Conflicts: # src/Network/Network/ChangeLog.md # tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv
Co-authored-by: JunKai-v <v-juphang@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…changes-2025-07-01 # Conflicts: # src/Network/Network/ChangeLog.md
…to arjun/vnra-vnet-ps-changes-2025-07-01 # Conflicts: # src/Network/Network.Management.Sdk/Generated/Models/VirtualNetwork.cs # src/Network/Network.Management.Sdk/Generated/Models/VirtualNetworkAppliance.cs # src/Network/Network.Management.Sdk/Generated/Models/VirtualNetworkApplianceIpVersionType.cs # src/Network/Network.Management.Sdk/Generated/Models/VirtualNetworkPropertiesFormat.cs # src/Network/Network.Management.Sdk/Generated/ResourceNavigationLinksOperations.cs # src/Network/Network.Management.Sdk/Generated/ServiceAssociationLinksOperations.cs # src/Network/Network.Management.Sdk/Generated/SubnetsOperations.cs # src/Network/Network.Management.Sdk/Generated/VirtualNetworkAppliancesOperations.cs # src/Network/Network.Management.Sdk/Generated/VirtualNetworkPeeringsOperations.cs # src/Network/Network.Management.Sdk/Generated/VirtualNetworksOperations.cs # src/Network/Network.Management.Sdk/README.md # src/Network/Network/ChangeLog.md # src/Network/Network/VirtualNetworkAppliance/NewVirtualNetworkApplianceCommand.cs # src/Network/Network/help/New-AzVirtualNetwork.md # src/Network/Network/help/New-AzVirtualNetworkAppliance.md
Hi @YanaXu, yes, the auto generated files are reverted now. Can you review again? |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
VeryEarly
left a comment
There was a problem hiding this comment.
breaking changes suppressed are not false positive. Please resolve them instead of suppresion
…to arjun/vnra-vnet-ps-changes-2025-07-01 # Conflicts: # src/Network/Network/ChangeLog.md
…07-01' into arjun/vnra-vnet-ps-changes-2025-07-01
…to string Revert PSVirtualNetworkAppliance.BandwidthInGbps from double? back to string, remove the 4 suppressed breaking-change entries from BreakingChangeIssues.csv, and update VNA scenario test assertions to string "50". Addresses reviewer feedback to resolve the breaking change instead of suppressing it.
I changed it back to string |
The VNA breaking-change suppressions were already removed; the only remaining diff was an added trailing newline. Restore the file to match the base branch so it is no longer part of the PR.
…ert) The -Bandwidth parameter type (string) and its numeric validation are unchanged from the shipped release, so the entry described a non-change. Genuine new features (PrivateIPAddressVersion, SummarizedGatewayPrefix) remain documented.
…list Use quoted string bandwidth values in examples (matches string parameter) and remove the enumerated valid values from the -Bandwidth description.
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
9fcad1b
into
Azure:release-network-2025-07-01
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.