Switch gzip compression to klauspost/compress#335
Open
matucker-msft wants to merge 1 commit into
Open
Conversation
Member
Author
|
Just here to say I am definitely a human. Feel free to reach out on teams with any concerns (or here in github if you want to keep it public, I dont care!). I understand the concerns of adding a dependency, but I also understand the concerns of gzip compression taking more time and cpu. We get value out of swapping this out and have been maintaining a fork since Jason originally opened his PR. I dont like maintaining forks, so I am here again :) |
Member
|
Hello - we would prefer not having to fork please - we have been using this library for a while ant it is superior in performance - thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
Replace
compress/gzipwithgithub.com/klauspost/compress/gzip(v1.18.5) for upload compression in the ingest pipeline.Why
klauspost/compress is an optimized, drop-in replacement for the standard library's compress/gzip package that provides:
compress/gzip, no code changes needed beyond the import pathFor ingestion workloads that compress data before uploading to Kusto, the improved compression throughput reduces CPU time and lowers end-to-end ingest latency.
This was previously raised in #205, and closed because "we rather not include extra deps unless it's critical." I am re-opening as a sign that this is critical and drastically improves compression time and cpu utilization.