Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="3.9.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.9.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="3.9.0" />
<PackageVersion Include="Microsoft.DurableTask.Client.Grpc" Version="1.12.0" />
<PackageVersion Include="Microsoft.DurableTask.Worker.Grpc" Version="1.12.0" />
<PackageVersion Include="Microsoft.DurableTask.Client.Grpc" Version="1.14.0" />
<PackageVersion Include="Microsoft.DurableTask.Worker.Grpc" Version="1.14.0" />
<PackageVersion Include="Microsoft.DurableTask.Analyzers" Version="0.1.0" />
<PackageVersion Include="Microsoft.Extensions.Azure" Version="1.7.0" />
<PackageVersion Include="Microsoft.Extensions.Http" Version="6.0.0" />
Expand Down Expand Up @@ -67,7 +67,7 @@
<PackageVersion Include="Microsoft.CodeAnalysis" Version="3.9.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.MSBuild" Version="3.9.0" />
<PackageVersion Include="Microsoft.Diagnostics.Tracing.TraceEvent" Version="2.0.65" />
<PackageVersion Include="Microsoft.DurableTask.Abstractions" Version="1.12.0" />
<PackageVersion Include="Microsoft.DurableTask.Abstractions" Version="1.14.0" />
<PackageVersion Include="Microsoft.DurableTask.Generators" Version="1.0.0-preview.1" />
<PackageVersion Include="Microsoft.DurableTask.SqlServer.AzureFunctions" Version="1.5.0" />
<PackageVersion Include="Microsoft.Extensions.Configuration" Version="9.0.0" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.IO;
using System.Linq;
using System.Net.Http;
using System.Threading;
Expand Down Expand Up @@ -1158,6 +1157,16 @@ async Task<string> IDurableOrchestrationClient.RestartAsync(string instanceId, b
throw new ArgumentException($"An orchestrastion with the instanceId {instanceId} was not found.");
}

bool isInstaceNotCompleted = status.RuntimeStatus == OrchestrationRuntimeStatus.Running ||
status.RuntimeStatus == OrchestrationRuntimeStatus.Pending ||
status.RuntimeStatus == OrchestrationRuntimeStatus.Suspended;

if (isInstaceNotCompleted && !restartWithNewInstanceId)
{
throw new InvalidOperationException($"Instance '{instanceId}' cannot be restarted while it is in state '{status.RuntimeStatus}'. " +
"Wait until it has completed, or restart with a new instance ID.");
}

return restartWithNewInstanceId ? await ((IDurableOrchestrationClient)this).StartNewAsync(orchestratorFunctionName: status.Name, status.Input)
: await ((IDurableOrchestrationClient)this).StartNewAsync(orchestratorFunctionName: status.Name, instanceId: status.InstanceId, status.Input);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ message EntityOperationCalledEvent {
}

message EntityLockRequestedEvent {
string criticalSectionId = 1;
string criticalSectionId = 1;
repeated string lockSet = 2;
int32 position = 3;
google.protobuf.StringValue parentInstanceId = 4; // used only within messages, null in histories
Expand All @@ -218,7 +218,7 @@ message EntityUnlockSentEvent {
message EntityLockGrantedEvent {
string criticalSectionId = 1;
}

message HistoryEvent {
int32 eventId = 1;
google.protobuf.Timestamp timestamp = 2;
Expand All @@ -245,8 +245,8 @@ message HistoryEvent {
ExecutionResumedEvent executionResumed = 22;
EntityOperationSignaledEvent entityOperationSignaled = 23;
EntityOperationCalledEvent entityOperationCalled = 24;
EntityOperationCompletedEvent entityOperationCompleted = 25;
EntityOperationFailedEvent entityOperationFailed = 26;
EntityOperationCompletedEvent entityOperationCompleted = 25;
EntityOperationFailedEvent entityOperationFailed = 26;
EntityLockRequestedEvent entityLockRequested = 27;
EntityLockGrantedEvent entityLockGranted = 28;
EntityUnlockSentEvent entityUnlockSent = 29;
Expand All @@ -258,13 +258,15 @@ message ScheduleTaskAction {
google.protobuf.StringValue version = 2;
google.protobuf.StringValue input = 3;
map<string, string> tags = 4;
TraceContext parentTraceContext = 5;
}

message CreateSubOrchestrationAction {
string instanceId = 1;
string name = 2;
google.protobuf.StringValue version = 3;
google.protobuf.StringValue input = 4;
TraceContext parentTraceContext = 5;
}

message CreateTimerAction {
Expand Down Expand Up @@ -314,6 +316,11 @@ message OrchestratorAction {
}
}

message OrchestrationTraceContext {
google.protobuf.StringValue spanID = 1;
google.protobuf.Timestamp spanStartTime = 2;
}

message OrchestratorRequest {
string instanceId = 1;
google.protobuf.StringValue executionId = 2;
Expand All @@ -322,6 +329,8 @@ message OrchestratorRequest {
OrchestratorEntityParameters entityParameters = 5;
bool requiresHistoryStreaming = 6;
map<string, google.protobuf.Value> properties = 7;

OrchestrationTraceContext orchestrationTraceContext = 8;
}

message OrchestratorResponse {
Expand All @@ -333,6 +342,8 @@ message OrchestratorResponse {
// The number of work item events that were processed by the orchestrator.
// This field is optional. If not set, the service should assume that the orchestrator processed all events.
google.protobuf.Int32Value numEventsProcessed = 5;

OrchestrationTraceContext orchestrationTraceContext = 6;
}

message CreateInstanceRequest {
Expand Down Expand Up @@ -471,6 +482,15 @@ message PurgeInstancesResponse {
google.protobuf.BoolValue isComplete = 2;
}

message RestartInstanceRequest {
string instanceId = 1;
bool restartWithNewInstanceId = 2;
}

message RestartInstanceResponse {
string instanceId = 1;
}

message CreateTaskHubRequest {
bool recreateIfExists = 1;
}
Expand Down Expand Up @@ -498,7 +518,7 @@ message SignalEntityRequest {
}

message SignalEntityResponse {
// no payload
// no payload
}

message GetEntityRequest {
Expand Down Expand Up @@ -671,18 +691,21 @@ service TaskHubSidecarService {
// Rewinds an orchestration instance to last known good state and replays from there.
rpc RewindInstance(RewindInstanceRequest) returns (RewindInstanceResponse);

// Restarts an orchestration instance.
rpc RestartInstance(RestartInstanceRequest) returns (RestartInstanceResponse);

// Waits for an orchestration instance to reach a running or completion state.
rpc WaitForInstanceStart(GetInstanceRequest) returns (GetInstanceResponse);

// Waits for an orchestration instance to reach a completion state (completed, failed, terminated, etc.).
rpc WaitForInstanceCompletion(GetInstanceRequest) returns (GetInstanceResponse);

// Raises an event to a running orchestration instance.
rpc RaiseEvent(RaiseEventRequest) returns (RaiseEventResponse);

// Terminates a running orchestration instance.
rpc TerminateInstance(TerminateRequest) returns (TerminateResponse);

// Suspends a running orchestration instance.
rpc SuspendInstance(SuspendRequest) returns (SuspendResponse);

Expand Down Expand Up @@ -764,7 +787,7 @@ message CompleteTaskResponse {
}

message HealthPing {
// No payload
// No payload
}

message StreamInstanceHistoryRequest {
Expand All @@ -777,4 +800,4 @@ message StreamInstanceHistoryRequest {

message HistoryChunk {
repeated HistoryEvent events = 1;
}
}
4 changes: 2 additions & 2 deletions src/WebJobs.Extensions.DurableTask/Grpc/Protos/versions.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# The following files were downloaded from branch main at 2025-06-12 23:59:39 UTC
https://raw.githubusercontent.com/microsoft/durabletask-protobuf/fd9369c6a03d6af4e95285e432b7c4e943c06970/protos/orchestrator_service.proto
# The following files were downloaded from branch main at 2025-09-11 18:23:56 UTC
https://raw.githubusercontent.com/microsoft/durabletask-protobuf/985035a0890575ae18be0eb2a3ac93c10824498a/protos/orchestrator_service.proto
23 changes: 23 additions & 0 deletions src/WebJobs.Extensions.DurableTask/TaskHubGrpcServer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,29 @@ private OrchestrationStatus[] GetStatusesNotToOverride()
return CreateGetInstanceResponse(state, request);
}

public override async Task<P.RestartInstanceResponse> RestartInstance(P.RestartInstanceRequest request, ServerCallContext context)
{
try
{
string newInstanceId = await this.GetClient(context).RestartAsync(request.InstanceId, request.RestartWithNewInstanceId);
return new P.RestartInstanceResponse { InstanceId = newInstanceId };
}
catch (ArgumentException ex)
{
// Thrown when th instanceId is not found.
throw new RpcException(new Status(StatusCode.NotFound, $"ArgumentException: {ex.Message}"));
}
catch (InvalidOperationException ex)
{
throw new RpcException(new Status(StatusCode.FailedPrecondition, $"InvalidOperationException: {ex.Message}"));
}
catch (Exception ex)
{
// Any other unexpected exceptions.
throw new RpcException(new Status(StatusCode.Unknown, ex.Message));
}
}

#pragma warning disable CS0618 // Type or member is obsolete -- 'internal' usage.
private static RawInput Raw(string input)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
<AssemblyName>Microsoft.Azure.WebJobs.Extensions.DurableTask</AssemblyName>
<RootNamespace>Microsoft.Azure.WebJobs.Extensions.DurableTask</RootNamespace>
<MajorVersion>3</MajorVersion>
<MinorVersion>4</MinorVersion>
<PatchVersion>1</PatchVersion>
<MinorVersion>5</MinorVersion>
<PatchVersion>0</PatchVersion>
<VersionPrefix>$(MajorVersion).$(MinorVersion).$(PatchVersion)</VersionPrefix>
<FileVersion>$(MajorVersion).$(MinorVersion).$(PatchVersion)</FileVersion>
<AssemblyVersion>$(MajorVersion).0.0.0</AssemblyVersion>
Expand Down
2 changes: 1 addition & 1 deletion src/Worker.Extensions.DurableTask/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
using Microsoft.Azure.Functions.Worker.Extensions.Abstractions;

// TODO: Find a way to generate this dynamically at build-time
[assembly: ExtensionInformation("Microsoft.Azure.WebJobs.Extensions.DurableTask", "3.4.1")]
[assembly: ExtensionInformation("Microsoft.Azure.WebJobs.Extensions.DurableTask", "3.5.0")]
[assembly: InternalsVisibleTo("Worker.Extensions.DurableTask.Tests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100cd1dabd5a893b40e75dc901fe7293db4a3caf9cd4d3e3ed6178d49cd476969abe74a9e0b7f4a0bb15edca48758155d35a4f05e6e852fff1b319d103b39ba04acbadd278c2753627c95e1f6f6582425374b92f51cca3deb0d2aab9de3ecda7753900a31f70a236f163006beefffe282888f85e3c76d1205ec7dfef7fa472a17b1")]
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@ static string BuildUrl(string url, params string?[] queryValues)
{
Id = instanceId,
PurgeHistoryDeleteUri = BuildUrl(instanceUrl, commonQueryParameters),
RestartPostUri = BuildUrl($"{instanceUrl}/restart", commonQueryParameters),
SendEventPostUri = BuildUrl($"{instanceUrl}/raiseEvent/{{eventName}}", commonQueryParameters),
StatusQueryGetUri = BuildUrl(instanceUrl, commonQueryParameters),
TerminatePostUri = BuildUrl($"{instanceUrl}/terminate", "reason={{text}}", commonQueryParameters),
Expand Down Expand Up @@ -319,7 +320,6 @@ private static ObjectSerializer GetObjectSerializer(HttpResponseData response)
return $"{proto}://{host}";
}


private static string? GetQueryParams(DurableTaskClient client)
{
return client is FunctionsDurableTaskClient functions ? functions.QueryString : null;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Copyright (c) .NET Foundation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.

using System;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.DurableTask;
Expand Down Expand Up @@ -102,4 +103,10 @@ public override Task<OrchestrationMetadata> WaitForInstanceStartAsync(
{
return this.inner.WaitForInstanceStartAsync(instanceId, getInputsAndOutputs, cancellation);
}

public override Task<string> RestartAsync(
string instanceId, bool restartWithNewInstanceId = false,CancellationToken cancellation = default)
{
return this.inner.RestartAsync(instanceId, restartWithNewInstanceId, cancellation);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<AssemblyOriginatorKeyFile>..\..\sign.snk</AssemblyOriginatorKeyFile>

<!-- Version information -->
<VersionPrefix>1.7.1</VersionPrefix>
<VersionPrefix>1.8.0</VersionPrefix>
<VersionSuffix></VersionSuffix>
<AssemblyVersion>$(VersionPrefix).0</AssemblyVersion>
<!-- FileVersionRevision is expected to be set by the CI. -->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ private static void AssertHttpManagementPayload(HttpManagementPayload payload, s
{
Assert.Equal(instanceId, payload.Id);
Assert.Equal($"{BaseUrl}/instances/{instanceId}", payload.PurgeHistoryDeleteUri);
Assert.Equal($"{BaseUrl}/instances/{instanceId}/restart", payload.RestartPostUri);
Assert.Equal($"{BaseUrl}/instances/{instanceId}/raiseEvent/{{eventName}}", payload.SendEventPostUri);
Assert.Equal($"{BaseUrl}/instances/{instanceId}", payload.StatusQueryGetUri);
Assert.Equal($"{BaseUrl}/instances/{instanceId}/terminate?reason={{{{text}}}}", payload.TerminatePostUri);
Expand Down
Loading
Loading