[MySQL] az mysql flexible-server mirroring enable/disable: Support Fabric Mirroring#33774
[MySQL] az mysql flexible-server mirroring enable/disable: Support Fabric Mirroring#33774mohitsinha-ms wants to merge 6 commits into
az mysql flexible-server mirroring enable/disable: Support Fabric Mirroring#33774Conversation
|
Hi @mohitsinha-ms, |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
az mysql flexible-server mirroring enable/disable: Support Fabric Mirroring
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure CLI MySQL module to support Microsoft Fabric Mirroring enable/disable for Azure Database for MySQL Flexible Server, including wiring up new CLI commands and adding a live scenario test. It also bumps the MySQL Flexible Server management SDK dependency to a newer beta required for the mirroring settings model shape.
Changes:
- Bump
azure-mgmt-mysqlflexibleserversfrom1.1.0b2to1.1.0b3across setup/requirements. - Add
az mysql flexible-server mirroring enable|disablecommands (params, help, command registration, client factory, custom handlers). - Add a new scenario test covering enable/disable flow.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/setup.py | Bumps MySQL flexible server management SDK version. |
| src/azure-cli/requirements.py3.windows.txt | Keeps Windows pinned requirements in sync with the SDK bump. |
| src/azure-cli/requirements.py3.Linux.txt | Keeps Linux pinned requirements in sync with the SDK bump. |
| src/azure-cli/requirements.py3.Darwin.txt | Keeps macOS pinned requirements in sync with the SDK bump. |
| src/azure-cli/azure/cli/command_modules/mysql/tests/latest/test_mysql_scenario.py | Adds a live scenario test for mirroring enable/disable. |
| src/azure-cli/azure/cli/command_modules/mysql/custom.py | Implements mirroring enable/disable custom handlers and payload builder. |
| src/azure-cli/azure/cli/command_modules/mysql/commands.py | Registers the new mysql flexible-server mirroring command group. |
| src/azure-cli/azure/cli/command_modules/mysql/_params.py | Adds arguments for the new mirroring commands. |
| src/azure-cli/azure/cli/command_modules/mysql/_help.py | Adds help entries and examples for the new mirroring commands. |
| src/azure-cli/azure/cli/command_modules/mysql/_client_factory.py | Adds a client factory for Fabric mirroring settings operations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
MySQL |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 33774 in repo Azure/azure-cli |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
@microsoft-github-policy-service agree company="Microsoft" |
|
@a0x1ab -- Please help with your code review. Thank you. |
Related command
az mysql flexible-server mirroring enable/az mysql flexible-server mirroring disableDescription
Adds CLI support for Microsoft Fabric Mirroring on Azure Database for MySQL Flexible Server via a new
mirroringsubgroup:az mysql flexible-server mirroring enable -g <rg> -n <server> --identity-resource-id <uami>az mysql flexible-server mirroring disable -g <rg> -n <server>These wrap the
fabricMirroringSettings/DefaultARM resource (API version2025-12-01-preview, added in Azure/azure-rest-api-specs#39083), an async PUT withstate = Enabled|Disabledand a user-assigned managed identity.This PR also bumps
azure-mgmt-mysqlflexibleservers1.1.0b2→1.1.0b3, the first SDK version exposingFabricMirroringSettingsOperations(begin_create_or_update,get,list_by_server); without it the command fails withAttributeError: 'MySQLManagementClient' object has no attribute 'fabric_mirroring_settings'. It also fixes the request-body construction incustom.pyto match the 1.1.0b3 model (nestedproperties.state/properties.identityResourceId). Supersedes #32708.Testing Guide
Prerequisites: register the preview feature (
az feature register --namespace Microsoft.DBforMySQL --name enableFabricMirroring_publicthenaz provider register --namespace Microsoft.DBforMySQL); a non-HA General Purpose MySQL 8.0 server withbinlog_row_image=FULL(orNOBLOB),gtid_mode=OFF,aad_auth_only=OFF; and a user-assigned managed identity attached to the server.Verified end-to-end against a live server (enable →
Enabled, disable →Disabled). Automated scenario test added intest_mysql_scenario.py.History Notes
[MySQL]
az mysql flexible-server mirroring: Addenableanddisablecommands to support Fabric MirroringThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.
🤖 PR Validation —⚠️ Review suggested