Skip to content

NetworkCloud CLI for the 2026-05-01-preview API#9867

Merged
necusjz merged 7 commits into
Azure:mainfrom
idanielsteven:main
May 28, 2026
Merged

NetworkCloud CLI for the 2026-05-01-preview API#9867
necusjz merged 7 commits into
Azure:mainfrom
idanielsteven:main

Conversation

@idanielsteven

Copy link
Copy Markdown
Contributor

NetworkCloud CLI for the 2026-05-01-preview API

aaz: Azure/aaz#1008

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings May 13, 2026 18:40
@azure-client-tools-bot-prd

azure-client-tools-bot-prd Bot commented May 13, 2026

Copy link
Copy Markdown
⚠️Azure CLI Extensions Breaking Change Test
⚠️networkcloud
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd networkcloud baremetalmachine reimage cmd networkcloud baremetalmachine reimage added parameter safeguard_mode
⚠️ 1006 - ParaAdd networkcloud cluster continue-update-version cmd networkcloud cluster continue-update-version added parameter safeguard_mode
⚠️ 1001 - CmdAdd networkcloud cluster rotate-credential cmd networkcloud cluster rotate-credential added
⚠️ 1006 - ParaAdd networkcloud cluster update-version cmd networkcloud cluster update-version added parameter safeguard_mode
⚠️ 1010 - ParaPropUpdate networkcloud virtualmachine create cmd networkcloud virtualmachine create update parameter network_data_content: updated property aaz_type from string to AAZPasswordArg
⚠️ 1010 - ParaPropUpdate networkcloud virtualmachine create cmd networkcloud virtualmachine create update parameter network_data_content: updated property type from string to Password
⚠️ 1010 - ParaPropUpdate networkcloud virtualmachine create cmd networkcloud virtualmachine create update parameter user_data_content: updated property aaz_type from string to AAZPasswordArg
⚠️ 1010 - ParaPropUpdate networkcloud virtualmachine create cmd networkcloud virtualmachine create update parameter user_data_content: updated property type from string to Password

@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi @idanielsteven,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan

yonzhan commented May 13, 2026

Copy link
Copy Markdown
Collaborator

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions

Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the NetworkCloud Azure CLI extension to target the 2026-05-01-preview NetworkCloud API and adds support for new/updated command behavior in the generated AAZ command layer.

Changes:

  • Bumps extension version/history and updates command API versions from 2026-01-01-preview to 2026-05-01-preview.
  • Adds new cluster rotate-credential command and related scenario coverage.
  • Updates generated schemas/arguments for new API fields, enum values, password handling, and safeguard options.

Reviewed changes

Copilot reviewed 163 out of 206 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/networkcloud/setup.py Bumps extension version and description API version.
src/networkcloud/HISTORY.rst Adds 5.0.0b2 release note.
src/networkcloud/azext_networkcloud/tests/latest/test_cluster.py Adds rotate-credential scenario and fixes scenario cleanup routing.
src/networkcloud/azext_networkcloud/tests/latest/config.ini Adds rotate credential test config.
src/networkcloud/azext_networkcloud/tests/latest/recordings/test_racksku_scenario1.yaml Updates recorded API version.
src/networkcloud/azext_networkcloud/tests/latest/recordings/test_clustermanager_scenario5.yaml Updates recorded API version.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/cluster/_rotate_credential.py Adds generated rotate-credential command.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/cluster/__init__.py Registers rotate-credential command module.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/cluster/_create.py Updates API version, schemas, enums, and password handling.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/cluster/_update.py Updates API version, schemas, enums, and password handling.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/cluster/_show.py Updates API version and response schema.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/cluster/_list.py Updates API version and response schema.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/cluster/_wait.py Updates API version and response schema.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/cluster/_continue_update_version.py Adds safeguard mode and updates API version.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/cluster/_update_version.py Adds safeguard mode and updates API version.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/baremetalmachine/_reimage.py Adds safeguard mode body and updates API version.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/baremetalmachine/_replace.py Updates password argument handling and API version.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/baremetalmachine/_show.py Updates API version and monitoring schema.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/baremetalmachine/_list.py Updates API version and monitoring schema.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/baremetalmachine/_wait.py Updates API version and monitoring schema.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/storageappliance/_show.py Updates API version and monitoring schema.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/storageappliance/_list.py Updates API version and monitoring schema.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/storageappliance/_wait.py Updates API version and monitoring schema.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/volume/_create.py Updates API version, enum validation, and volume schema.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/volume/_list.py Updates API version and volume schema.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/virtualmachine/_create.py Updates API version, extended location schema, and secret-style args.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/virtualmachine/_update.py Updates API version, extended location schema, and password arg.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/virtualmachine/_show.py Updates API version and response schema.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/virtualmachine/_list.py Updates API version and response schema.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/clustermanager/_create.py Updates API version and kind validation.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/* Updates remaining generated NetworkCloud command files to 2026-05-01-preview.

Comment thread src/networkcloud/azext_networkcloud/tests/latest/config.ini Outdated
@github-actions

Copy link
Copy Markdown
Contributor

Hi @idanielsteven

⚠️ Release Requirements

Module: networkcloud

  • ⚠️ Set azext.isPreview to true in azext_metadata.json for networkcloud

Notes

@github-actions github-actions Bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 13, 2026
@yonzhan yonzhan requested a review from necusjz May 13, 2026 23:25
@idanielsteven idanielsteven marked this pull request as draft May 14, 2026 20:04
@idanielsteven idanielsteven marked this pull request as ready for review May 27, 2026 14:32
@necusjz

necusjz commented May 27, 2026

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@idanielsteven

Copy link
Copy Markdown
Contributor Author

Our release version is correct.

@necusjz

necusjz commented May 27, 2026

Copy link
Copy Markdown
Member

Our release version is correct.

@idanielsteven could you please sync with the latest main branch and push again? recently, there is an enhancement for that check. thanks.

@necusjz

necusjz commented May 27, 2026

Copy link
Copy Markdown
Member

@idanielsteven from the error msg, please "Set azext.isPreview to true in azext_metadata.json for networkcloud".

@idanielsteven

idanielsteven commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

@idanielsteven from the error msg, please "Set azext.isPreview to true in azext_metadata.json for networkcloud".

@necusjz This is already the case - there is no diff here because our last version was also a preview - is that why the warning is occurring - no diff on that file?

@idanielsteven

idanielsteven commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

Our release version is correct.

@idanielsteven could you please sync with the latest main branch and push again? recently, there is an enhancement for that check. thanks.

@necusjz This is done.

@necusjz necusjz removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 28, 2026
@necusjz necusjz merged commit 72ddb7f into Azure:main May 28, 2026
35 of 36 checks passed
@azclibot

Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ networkcloud-5.0.0b2 ] : https://dev.azure.com/msazure/One/_build/results?buildId=165822620&view=results

s-ddavydenko pushed a commit to s-ddavydenko/azure-cli-extensions that referenced this pull request May 29, 2026
* Managed Network Fabric CLI updates for new 2026-01-15-preview API

* Managed Network Fabric CLI updates for new 2026-01-15-preview API

* NetworkCloud CLI for the 2026-05-01-preview API

* NetworkCloud CLI for the 2026-05-01-preview API

* retrigger checks
necusjz pushed a commit that referenced this pull request Jun 2, 2026
* remove dpericated --location

* style

* update history

* NetworkCloud CLI for the 2026-05-01-preview API (#9867)

* Managed Network Fabric CLI updates for new 2026-01-15-preview API

* Managed Network Fabric CLI updates for new 2026-01-15-preview API

* NetworkCloud CLI for the 2026-05-01-preview API

* NetworkCloud CLI for the 2026-05-01-preview API

* retrigger checks

* [Release] Update index.json for extension [ networkcloud-5.0.0b2 ]

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=165822620&view=results

Last commit: 72ddb7f

* Quantum: workspace create and set related bug fixes (#9906)

* Fix workspace create, tested

* Worspace set command improvements

* [Release] Update index.json for extension [ quantum-1.0.0b15 ]

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=165988604&view=results

Last commit: f561f26

* [Microsoft.ChangeSafety][BugFix] fix additional data parsing issue (#9901)

* Fix --additional-data and --change-definition to accept free-form nested JSON

The --additional-data argument was defined as AAZObjectArg with no child
fields, causing 'Model AAZObjectArg has no field named safeFly' errors.
The --change-definition details field had the same issue, rejecting
ApiOperations payloads with 'no field named operations'.

Changes:
- Change additional_data from AAZObjectArg to AAZFreeFormDictArg
- Change change_definition.details from AAZObjectArg to AAZFreeFormDictArg
- Change corresponding AAZObjectType to AAZFreeFormDictType in builders
  and response schemas across create, update, show, and list
- Add content injection for additionalData in custom.py (same pattern as
  changeDefinition) to work around AAZ builder serialization limitation
- Add tests for SafeFly payload, links, and orchestration-tool arguments
- Bump version to 1.0.0b2

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Retrigger CI (transient GitHub 403 incident on prior run)

* Address PR nits: use 'is None' / 'is not None' for additional_data checks

Per review feedback, replace truthiness checks with explicit None checks so
that an explicitly provided empty dict {} is treated as a valid user-supplied
value rather than being silently dropped.

- _inject_additional_data_into_content: 'if not additional_data' -> 'is None'
- ChangeRecordCreate.pre_operations: 'if additional_data' -> 'is not None'
- ChangeRecordUpdate.pre_operations: same fix for consistency (duplicated pattern)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Henry Dai <henrydai@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* [Release] Update index.json for extension [ azure-changesafety-1.0.0b2 ]

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=166044594&view=results

Last commit: b145cb5

* style

* history log

* delete empty breaking_changes file

* version bump in setup.py

---------

Co-authored-by: idanielsteven <danielsteven@microsoft.com>
Co-authored-by: Azure CLI Team <AzPyCLI@microsoft.com>
Co-authored-by: Zulfat Nutfullin <rigidit@users.noreply.github.com>
Co-authored-by: likesys <henry.zekun.dai@outlook.com>
Co-authored-by: Henry Dai <henrydai@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants