Skip to content

add more test coverage to native kbkdf tests#528

Open
meilu-git wants to merge 4 commits into
mainfrom
meilu/native_azihsm_kbkdf
Open

add more test coverage to native kbkdf tests#528
meilu-git wants to merge 4 commits into
mainfrom
meilu/native_azihsm_kbkdf

Conversation

@meilu-git

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands the native (C/C++) KBKDF test suite to cover additional parameter combinations (label/context variants), more HMAC algorithms, and additional negative validation cases, improving confidence in KBKDF derive behavior and key-property validation.

Changes:

  • Added helper functions to derive via KBKDF with custom label/context inputs.
  • Added new positive roundtrip tests (context-only, additional HMAC algos, AES-128/192).
  • Added new negative tests for invalid buffers and invalid/unsupported key properties.

Comment thread api/tests/cpp/algo/kdf/kbkdf_tests.cpp Outdated
Comment thread api/tests/cpp/algo/kdf/kbkdf_tests.cpp Outdated
Comment thread api/tests/cpp/algo/kdf/kbkdf_tests.cpp Outdated
Comment thread api/tests/cpp/algo/kdf/kbkdf_tests.cpp Outdated
Comment thread api/tests/cpp/algo/kdf/kbkdf_tests.cpp Outdated
Copilot AI review requested due to automatic review settings July 9, 2026 04:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread api/tests/cpp/algo/kdf/kbkdf_tests.cpp Outdated
Comment thread api/tests/cpp/algo/kdf/kbkdf_tests.cpp Outdated
Copilot AI review requested due to automatic review settings July 10, 2026 19:39
@meilu-git meilu-git force-pushed the meilu/native_azihsm_kbkdf branch from fae1292 to e49b1ff Compare July 10, 2026 19:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Comment thread api/tests/cpp/algo/kdf/kbkdf_tests.cpp Outdated
Comment thread api/tests/cpp/algo/kdf/kbkdf_tests.cpp
Comment thread api/tests/cpp/algo/kdf/kbkdf_tests.cpp
Copilot AI review requested due to automatic review settings July 10, 2026 19:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants