Skip to content

add test coverage to native secret unmask tests#507

Open
meilu-git wants to merge 5 commits into
mainfrom
meilu/native_azihsm_secret_unmask
Open

add test coverage to native secret unmask tests#507
meilu-git wants to merge 5 commits into
mainfrom
meilu/native_azihsm_secret_unmask

Conversation

@meilu-git

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Expands the GoogleTest C++ integration coverage for the native azihsm_key_unmask path for shared-secret (generic secret) keys, exercising more invalid-argument and malformed masked-blob scenarios to harden unmask behavior.

Changes:

  • Added a helper to derive a shared secret and fetch its AZIHSM_KEY_PROP_ID_MASKED_KEY blob for reuse across tests.
  • Added many new negative/edge-case tests for azihsm_key_unmask (null pointers, malformed/truncated/corrupted blobs, wrong kind, invalid session, etc.).
  • Added coverage around masked-key property probing behavior and re-masking/unmasking flows.

Comment thread api/tests/cpp/algo/secret/unmask_tests.cpp
Comment thread api/tests/cpp/algo/secret/unmask_tests.cpp Outdated
Copilot AI review requested due to automatic review settings July 1, 2026 21:58
@meilu-git meilu-git force-pushed the meilu/native_azihsm_secret_unmask branch from 894e61f to ba2712d Compare July 1, 2026 21:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread api/tests/cpp/algo/secret/unmask_tests.cpp Outdated
Comment thread api/tests/cpp/algo/secret/unmask_tests.cpp Outdated
@meilu-git meilu-git force-pushed the meilu/native_azihsm_secret_unmask branch from ba2712d to ffb6f4e Compare July 2, 2026 15:34
Copilot AI review requested due to automatic review settings July 2, 2026 15:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants