Clarify comments on EVP_get_digestbyname usage#341
Open
CPiccini wants to merge 3 commits into
Open
Conversation
Updated comments to bypass CodeQL checks for required backward compatible param
Contributor
There was a problem hiding this comment.
Pull request overview
Updates inline comments around EVP_get_digestbyname usage in the OpenSSL provider RSA signature implementation, intended to clarify/justify the externally-provided digest name usage for CodeQL.
Changes:
- Consolidated/added CodeQL justification comments next to
EVP_get_digestbyname(...)calls in RSA sign/verify init and context parameter parsing.
Updated comments for clarity while maintaining backward compatibility.
Contributor
Author
|
@copilot apply changes based on the comments in this thread. Also make change so it passes cargofmt checks for length |
Agent-Logs-Url: https://github.com/Azure/azihsm-sdk/sessions/96f6eb21-f2f1-41c7-9f2d-72f1a32d4123 Co-authored-by: CPiccini <47435428+CPiccini@users.noreply.github.com>
Contributor
Implemented in commit f1f5c75. I replaced the non-standard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated comments to bypass CodeQL checks for required backward compatible param