Generate Generic Breaking Change Attribute#1508
Merged
Merged
Conversation
autorest.powershell\powershell\cmdlets\class.ts 2313:25 error Strings must use singlequote quotes
isra-fel
commented
Aug 26, 2025
| throw new Error('Cmdlet breaking change requires both \'deprecateByVersion\' and \'deprecateByAzVersion\', please refer to https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/breakingchange-for-autogen-module.md for more details.'); | ||
| } | ||
|
|
||
| if (!breakingChange.cmdlet.replacement && breakingChange.cmdlet.changeDescription) { |
Member
Author
There was a problem hiding this comment.
The core logic of this PR is this if-else. In the case when user preannounces a breaking change with changeDescription, we should prioritize showing it instead of the hardcoded "The cmdlet is being deprecated without replacement".
On the other hand, GenericBreakingChangeAttribute is a more fitting type than CmdletBreakingChangeAttribute in this case.
VeryEarly
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how breaking change attributes are added to PowerShell cmdlet classes.
It removes the extra sentence "The cmdlet is being deprecated. There will be no replacement for it." by generating different type of breaking change attribute. From
CmdletBreakingChangeAttributetoGenericBreakingChangeAttribute.That sentence can be misleading in many scenarios. See #1487 Azure/azure-powershell#28134
Test
Old:
New:
Bug Fix
ClientRuntimemapping by renamingGeneraricBreakingChangeAttributetoGenericBreakingChangeAttribute.