Skip to content

aks-desktop: Stop requiring ManagedNamespacePreview - #791

Open
skoeva wants to merge 1 commit into
Azure:mainfrom
skoeva:mns-preview
Open

aks-desktop: Stop requiring ManagedNamespacePreview#791
skoeva wants to merge 1 commit into
Azure:mainfrom
skoeva:mns-preview

Conversation

@skoeva

@skoeva skoeva commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

AKS Managed Namespaces are generally available and no longer require the ManagedNamespacePreview subscription feature. The Create Project wizard still checked this feature and blocked users when it was unavailable. This removes the obsolete requirement so project creation can proceed without feature registration.

Fixes: #788

Changes

  • Remove the ManagedNamespacePreview warning and registration action from the Create Project wizard
  • Stop checking feature registration when a subscription is selected
  • Remove feature registration from Basics-step validation
  • Remove the unused feature-check hook, Azure CLI registration helpers, types, stories, and test fixtures
  • Update the Azure utilities documentation to remove the obsolete feature-registration responsibility

Testing

  • npm run test:unit -- src/components/CreateAKSProject passes (123 tests)
  • Create a project in a subscription without ManagedNamespacePreview registered and confirm the wizard proceeds

@skoeva skoeva self-assigned this Jul 24, 2026
Copilot AI review requested due to automatic review settings July 24, 2026 19:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the obsolete ManagedNamespacePreview subscription feature requirement from the Create AKS Project wizard now that Azure Managed Namespaces are GA, unblocking project creation for subscriptions where that preview feature is not registered (Fixes #788).

Changes:

  • Removed ManagedNamespacePreview registration/status checks from wizard validation and UI, including the “register feature” action.
  • Deleted the now-unused feature-check hook and related types/props across the Create Project wizard surface.
  • Updated Azure utilities documentation to reflect the narrowed responsibilities of az-extensions.ts.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
plugins/aks-desktop/src/utils/azure/README.md Updates module responsibility docs to remove obsolete feature-registration mention.
plugins/aks-desktop/src/utils/azure/az-extensions.ts Removes ManagedNamespacePreview feature-check and registration helpers.
plugins/aks-desktop/src/components/CreateAKSProject/validators.ts Drops feature-registration as a basics-step validation requirement.
plugins/aks-desktop/src/components/CreateAKSProject/validators.test.ts Updates unit tests to match revised validation signature/behavior.
plugins/aks-desktop/src/components/CreateAKSProject/types.ts Removes FeatureStatus and related props/actions from step prop types.
plugins/aks-desktop/src/components/CreateAKSProject/hooks/useValidation.ts Stops threading feature status into step validation.
plugins/aks-desktop/src/components/CreateAKSProject/hooks/useFeatureCheck.ts Deletes unused feature-check hook implementation.
plugins/aks-desktop/src/components/CreateAKSProject/hooks/useCreateAKSProjectWizard.ts Removes feature-check wiring from the wizard orchestration hook.
plugins/aks-desktop/src/components/CreateAKSProject/hooks/useCreateAKSProjectWizard.test.ts Removes mocking of the deleted feature-check hook.
plugins/aks-desktop/src/components/CreateAKSProject/hooks/useBasicsStep.test.ts Updates step hook test props to remove feature-related fields.
plugins/aks-desktop/src/components/CreateAKSProject/CreateAKSProject.tsx Stops passing feature-related props/actions into Basics step.
plugins/aks-desktop/src/components/CreateAKSProject/components/BasicsStep.tsx Removes the feature-flag required error panel and “register feature” flow.
plugins/aks-desktop/src/components/CreateAKSProject/components/BasicsStep.stories.tsx Removes feature-registration stories and baseline props.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings July 24, 2026 20:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Comment thread Localize/locales/en/plugin-translation.json
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Copilot AI review requested due to automatic review settings July 27, 2026 11:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.

@sniok

sniok commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

In the bundled azure cli we also install "aks-preview" extension (packge.json:57), could you check if it is still needed since managed namespaces are no longer in preview? Although it might be required by some other features we use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Unable to create new project using Azure Managed Namespace

3 participants