aks-desktop: Stop requiring ManagedNamespacePreview - #791
Open
skoeva wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the obsolete ManagedNamespacePreview subscription feature requirement from the Create AKS Project wizard now that Azure Managed Namespaces are GA, unblocking project creation for subscriptions where that preview feature is not registered (Fixes #788).
Changes:
- Removed
ManagedNamespacePreviewregistration/status checks from wizard validation and UI, including the “register feature” action. - Deleted the now-unused feature-check hook and related types/props across the Create Project wizard surface.
- Updated Azure utilities documentation to reflect the narrowed responsibilities of
az-extensions.ts.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/aks-desktop/src/utils/azure/README.md | Updates module responsibility docs to remove obsolete feature-registration mention. |
| plugins/aks-desktop/src/utils/azure/az-extensions.ts | Removes ManagedNamespacePreview feature-check and registration helpers. |
| plugins/aks-desktop/src/components/CreateAKSProject/validators.ts | Drops feature-registration as a basics-step validation requirement. |
| plugins/aks-desktop/src/components/CreateAKSProject/validators.test.ts | Updates unit tests to match revised validation signature/behavior. |
| plugins/aks-desktop/src/components/CreateAKSProject/types.ts | Removes FeatureStatus and related props/actions from step prop types. |
| plugins/aks-desktop/src/components/CreateAKSProject/hooks/useValidation.ts | Stops threading feature status into step validation. |
| plugins/aks-desktop/src/components/CreateAKSProject/hooks/useFeatureCheck.ts | Deletes unused feature-check hook implementation. |
| plugins/aks-desktop/src/components/CreateAKSProject/hooks/useCreateAKSProjectWizard.ts | Removes feature-check wiring from the wizard orchestration hook. |
| plugins/aks-desktop/src/components/CreateAKSProject/hooks/useCreateAKSProjectWizard.test.ts | Removes mocking of the deleted feature-check hook. |
| plugins/aks-desktop/src/components/CreateAKSProject/hooks/useBasicsStep.test.ts | Updates step hook test props to remove feature-related fields. |
| plugins/aks-desktop/src/components/CreateAKSProject/CreateAKSProject.tsx | Stops passing feature-related props/actions into Basics step. |
| plugins/aks-desktop/src/components/CreateAKSProject/components/BasicsStep.tsx | Removes the feature-flag required error panel and “register feature” flow. |
| plugins/aks-desktop/src/components/CreateAKSProject/components/BasicsStep.stories.tsx | Removes feature-registration stories and baseline props. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Collaborator
|
In the bundled azure cli we also install |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AKS Managed Namespaces are generally available and no longer require the
ManagedNamespacePreviewsubscription feature. The Create Project wizard still checked this feature and blocked users when it was unavailable. This removes the obsolete requirement so project creation can proceed without feature registration.Fixes: #788
Changes
ManagedNamespacePreviewwarning and registration action from the Create Project wizardTesting
npm run test:unit -- src/components/CreateAKSProjectpasses (123 tests)ManagedNamespacePreviewregistered and confirm the wizard proceeds