Support upstream CCWS schedFilesystem parameter, including scheduler ANF options#132
Draft
wolfgang-desalvador with Copilot wants to merge 4 commits into
Draft
Support upstream CCWS schedFilesystem parameter, including scheduler ANF options#132wolfgang-desalvador with Copilot wants to merge 4 commits into
schedFilesystem parameter, including scheduler ANF options#132wolfgang-desalvador with Copilot wants to merge 4 commits into
Conversation
Agent-Logs-Url: https://github.com/Azure/ai-infrastructure-on-azure/sessions/0e0ce5ef-cadf-4202-a60c-b532c5a1a7b9 Co-authored-by: wolfgang-desalvador <118554802+wolfgang-desalvador@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Azure/ai-infrastructure-on-azure/sessions/d2487a40-69c6-460c-84e9-81920f831e30 Co-authored-by: wolfgang-desalvador <118554802+wolfgang-desalvador@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Azure/ai-infrastructure-on-azure/sessions/d2487a40-69c6-460c-84e9-81920f831e30 Co-authored-by: wolfgang-desalvador <118554802+wolfgang-desalvador@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
wolfgang-desalvador
May 25, 2026 08:25
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CycleCloud Workspace for Slurm deployment helper to generate the newly upstream-required schedFilesystem parameter (with optional scheduler ANF support) while remaining compatible with older workspace template revisions.
Changes:
- Added new CLI flags and validation for
/schedfilesystem selection (nfsvsanf) including Flexible-tier throughput and optional AZ. - Conditionally emits
schedFilesystemintooutput.jsononly when the checked-out workspace template declares the parameter. - Updated README and script help text to document
/schedconfiguration options.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| infrastructure_references/azure_cyclecloud_workspace_for_slurm/scripts/deploy-ccws.sh | Adds /sched filesystem CLI options, validation, AZ handling, and conditional schedFilesystem parameter emission. |
| infrastructure_references/azure_cyclecloud_workspace_for_slurm/README.md | Documents the new /sched filesystem options and updates the optional-parameters reference. |
| if [[ "$SCHED_ANF_SKU" == "Flexible" ]]; then | ||
| SCHED_ANF_THROUGHPUT_JSON=', "anfFlexThroughputMiBps": '"${SCHED_ANF_THROUGHPUT_MIBPS}" | ||
| fi | ||
| SCHED_FILESYSTEM_JSON='"schedFilesystem": { "value": { "type": "anf-new", "anfServiceLevel": "'"${SCHED_ANF_SKU}"'", "anfCapacityInTiB": '"${SCHED_ANF_SIZE}${SCHED_ANF_THROUGHPUT_JSON}${SCHED_ANF_ZONES_JSON}"' } },' |
wolfgang-desalvador
had a problem deploying
to
testing
May 25, 2026 09:26 — with
GitHub Actions
Failure
wolfgang-desalvador
had a problem deploying
to
testing
May 25, 2026 09:27 — with
GitHub Actions
Failure
Collaborator
Agent-Logs-Url: https://github.com/Azure/ai-infrastructure-on-azure/sessions/128b6422-b422-4ed0-bc5a-7db755d6a87c Co-authored-by: wolfgang-desalvador <118554802+wolfgang-desalvador@users.noreply.github.com>
Contributor
Author
Fixed in I checked the failing run/job logs and updated |
wolfgang-desalvador
had a problem deploying
to
testing
May 25, 2026 09:32 — with
GitHub Actions
Failure
wolfgang-desalvador
had a problem deploying
to
testing
May 25, 2026 09:53 — with
GitHub Actions
Failure
xpillons
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy-ccws.shand implement the smallest safe fix