Skip to content

Support upstream CCWS schedFilesystem parameter, including scheduler ANF options#132

Draft
wolfgang-desalvador with Copilot wants to merge 4 commits into
mainfrom
copilot/fix-azure-cyclecloud-workspace-parameters
Draft

Support upstream CCWS schedFilesystem parameter, including scheduler ANF options#132
wolfgang-desalvador with Copilot wants to merge 4 commits into
mainfrom
copilot/fix-azure-cyclecloud-workspace-parameters

Conversation

Copilot AI commented May 25, 2026

Copy link
Copy Markdown
Contributor
  • Investigate the failing GitHub Actions run and inspect job logs
  • Identify root cause in deploy-ccws.sh and implement the smallest safe fix
  • Run targeted validation for the changed script/docs
  • Run final parallel validation (Code Review + CodeQL)
  • Reply to the PR comment with the fixing commit hash

Copilot AI and others added 3 commits May 25, 2026 07:41
Agent-Logs-Url: https://github.com/Azure/ai-infrastructure-on-azure/sessions/0e0ce5ef-cadf-4202-a60c-b532c5a1a7b9

Co-authored-by: wolfgang-desalvador <118554802+wolfgang-desalvador@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Azure/ai-infrastructure-on-azure/sessions/d2487a40-69c6-460c-84e9-81920f831e30

Co-authored-by: wolfgang-desalvador <118554802+wolfgang-desalvador@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Azure/ai-infrastructure-on-azure/sessions/d2487a40-69c6-460c-84e9-81920f831e30

Co-authored-by: wolfgang-desalvador <118554802+wolfgang-desalvador@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CycleCloud Workspace for Slurm deployment helper to generate the newly upstream-required schedFilesystem parameter (with optional scheduler ANF support) while remaining compatible with older workspace template revisions.

Changes:

  • Added new CLI flags and validation for /sched filesystem selection (nfs vs anf) including Flexible-tier throughput and optional AZ.
  • Conditionally emits schedFilesystem into output.json only when the checked-out workspace template declares the parameter.
  • Updated README and script help text to document /sched configuration options.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
infrastructure_references/azure_cyclecloud_workspace_for_slurm/scripts/deploy-ccws.sh Adds /sched filesystem CLI options, validation, AZ handling, and conditional schedFilesystem parameter emission.
infrastructure_references/azure_cyclecloud_workspace_for_slurm/README.md Documents the new /sched filesystem options and updates the optional-parameters reference.

if [[ "$SCHED_ANF_SKU" == "Flexible" ]]; then
SCHED_ANF_THROUGHPUT_JSON=', "anfFlexThroughputMiBps": '"${SCHED_ANF_THROUGHPUT_MIBPS}"
fi
SCHED_FILESYSTEM_JSON='"schedFilesystem": { "value": { "type": "anf-new", "anfServiceLevel": "'"${SCHED_ANF_SKU}"'", "anfCapacityInTiB": '"${SCHED_ANF_SIZE}${SCHED_ANF_THROUGHPUT_JSON}${SCHED_ANF_ZONES_JSON}"' } },'
@wolfgang-desalvador

Copy link
Copy Markdown
Collaborator

Agent-Logs-Url: https://github.com/Azure/ai-infrastructure-on-azure/sessions/128b6422-b422-4ed0-bc5a-7db755d6a87c

Co-authored-by: wolfgang-desalvador <118554802+wolfgang-desalvador@users.noreply.github.com>

Copilot AI commented May 25, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Look at https://github.com/Azure/ai-infrastructure-on-azure/actions/runs/26393408138/job/77688266212 and fix

Fixed in e850dfb.

I checked the failing run/job logs and updated deploy-ccws.sh to emit sharedFilesystem.anfServiceLevel (instead of anfServiceTier), which matches the template schema that was causing the InvalidTemplate failure.

Copilot AI deployed to testing May 28, 2026 09:18 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants