Skip to content

Pin Dynamo precheck script download to release tag instead of main#127

Merged
wolfgang-desalvador merged 2 commits into
add-dynamo-examplesfrom
copilot/sub-pr-125-again
Mar 25, 2026
Merged

Pin Dynamo precheck script download to release tag instead of main#127
wolfgang-desalvador merged 2 commits into
add-dynamo-examplesfrom
copilot/sub-pr-125-again

Conversation

Copilot AI commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Downloading the pre-deployment check script from main is a supply-chain risk and breaks reproducibility if the upstream script changes between runs.

Change

  • Pin the precheck script URL to v${DYNAMO_VERSION} instead of main, matching the Helm chart version already used for the Dynamo platform installation
# Before
local precheck_url="https://raw.githubusercontent.com/ai-dynamo/dynamo/main/deploy/pre-deployment/pre-deployment-check.sh"

# After
local precheck_url="https://raw.githubusercontent.com/ai-dynamo/dynamo/v${DYNAMO_VERSION}/deploy/pre-deployment/pre-deployment-check.sh"

DYNAMO_VERSION already defaults to 1.0.1 at script initialization, so the URL is always well-formed.


📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Co-authored-by: wolfgang-desalvador <118554802+wolfgang-desalvador@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Azure/ai-infrastructure-on-azure/sessions/1e1e7e15-f086-482c-b959-74d3518641d3

Copilot AI commented Mar 23, 2026

Copy link
Copy Markdown
Contributor Author

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/ai-dynamo/dynamo/tags
    • Triggering command: /usr/bin/curl curl -fsSL REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] [WIP] Address feedback on "Add NVIDIA Dynamo" pull request Pin Dynamo precheck script download to release tag instead of main Mar 23, 2026
@wolfgang-desalvador
wolfgang-desalvador marked this pull request as ready for review March 24, 2026 10:42
@wolfgang-desalvador
wolfgang-desalvador merged commit 5f6a49e into add-dynamo-examples Mar 25, 2026
22 checks passed
@wolfgang-desalvador
wolfgang-desalvador deleted the copilot/sub-pr-125-again branch March 25, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants