Pin drifted deps: mcp<2, ruff==0.15.12 (main is red from upstream releases, not from code) - #62
Merged
Merged
Conversation
The last main CI run was 2026-06-26. In the six weeks since, two upstream releases broke CI on code that had not changed: - mcp 2.0.0 shipped and moved mcp.server.fastmcp. pyproject declared mcp>=1.20.0 with no upper bound, so CI resolved 2.0.0 and every FastMCP import failed with ModuleNotFoundError across all three Python versions. Pinned <2, which resolves to 1.29.0 and imports FastMCP cleanly. - The Lint job ran an unpinned pip install ruff, so a newer ruff surfaced 212 pre-existing violations (SIM117 and friends) in files nobody had touched. Pinned to 0.15.12, the version the tree is clean against, so lint is reproducible instead of drifting with each ruff release. Restores the known-good resolution rather than changing behavior. Upgrading to mcp 2.x or a newer ruff is deliberate work for its own PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is red, and not because of any code change
The last successful main CI run was 2026-06-26. PR #60 merged today and triggered the first run since, which exposed six weeks of unpinned-dependency drift. Both failures are in files no recent PR touched.
1. All three Python jobs:
ModuleNotFoundError: No module named 'mcp.server.fastmcp'pyproject.tomldeclaredmcp>=1.20.0with no upper bound.mcp 2.0.0has since shipped and moved that module, so CI resolved 2.0.0 and every FastMCP import died. Local dev was unaffected because the venv still holds 1.26.0.Fix:
mcp>=1.20.0,<2. Verified in a clean venv that this resolves to 1.29.0 and thatfrom mcp.server.fastmcp import FastMCPsucceeds.2. Lint: 212 errors in untouched files
The Lint job ran an unpinned
pip install ruff, so a newer ruff than local (0.15.12) reported 212 pre-existing violations (SIM117 and others) in files liketests/test_web_app_routes.py.Fix: pin
ruff==0.15.12, the version the tree is verifiably clean against (ruff check-> All checks passed,ruff format --check-> 94 files already formatted).Scope
Deliberately minimal: this restores the known-good resolution, it does not change behavior. Migrating to
mcp2.x, or upgrading ruff and clearing the 212 findings, are each deliberate pieces of work that deserve their own PR and review.🤖 Generated with Claude Code