Repository navigation
Factor detail: JSON-normalize before hash/store; seal-check rescore lines - #107
Merged
Merged
Conversation
…ines via RESCORE factor_detail_sha256
… own and previous detail are sealed
Owner
Author
|
Updated at 192a4b7 for AZBot's fail-open blocker:
|
…mps; reasoning seal via SUBMIT content_sha256
Owner
Author
|
Updated at fd00762 for AZBot's ordering blocker:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Off main d7f6a1d (#106 follow-up).
factorDetail()now returnsJSON.parse(JSON.stringify(raw)), so the hashed value and the stored triad_json bytes are identical. An undefined nested checker field can no longer cause a false 'not covered'.rescore_id) must match the verified checkpoint, and itsfactor_detail_sha256must equal the sha256 of that rescore's stored factor_detail. The line then ends '(covered by seal)'. Otherwise it ends '(stored data, not covered)'. A SUBMIT hash never seals a rescore line. The JSON gainsrescore_factor_changes[].idand.sealed.No new D1 queries: the RESCORE rows already come back in the indexed receipt_id read. Hash-linked and sealed, not signed.
Tests: 304/304 (normalized round trip, rescore covered, rescore edited after the write, SUBMIT hash not sealing a rescore). Not merged, not deployed.