Complete the post-creation wallet backup reminder#288
Merged
El-swaggerito merged 1 commit intoJul 23, 2026
Conversation
Make the backup reminder shown after wallet creation theme-aware, accessible, and covered by tests. - Render the reminder with the resolved theme palette instead of the hardcoded dark constants, so it matches the rest of the app in light mode. - Reset the confirmation checkbox when the reminder closes, so a reminder that reappears after an unacknowledged session starts unchecked. - Expose the confirmation as an accessible checkbox with a label and checked state, mark the overlay as a modal view, and add a header role to the title. - Allow the card to scroll at large font scales instead of clipping. - Export the component from the components barrel. - Document the reminder step in the create-wallet user flow. No key material is rendered by the reminder; the secret key stays behind the explicit reveal on the creation screen.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #256
Summary
The backup reminder shown after wallet creation existed but was only partly finished: it rendered from the hardcoded dark palette, exposed no accessibility semantics, was not part of the components barrel, had no test coverage, and was undocumented. This PR completes it against the issue's acceptance criteria.
What changed
src/components/BackupReminderModal.tsxuseTheme) instead of the hardcodedCOLORSconstants, so the reminder no longer appears as a dark card over a light-theme Home screen. The warning box now usessurfaceLight/borderrather than fixed white alpha values that were invisible on light surfaces.accessibilityRole="checkbox"with a label and a livecheckedstate, the title carries a header role, and the overlay is markedaccessibilityViewIsModalso assistive tech does not read the Home screen behind it.Other
BackupReminderModalfromsrc/components/index.ts.docs/user-flows.md.__tests__/BackupReminderModal.test.tsx.Acceptance criteria
showBackupReminderflag.Testing
5 tests, all passing: copy and absence of key material, the disabled-until-confirmed action, the accessible checkbox state, the reset on reopen, and that nothing renders while hidden.
The repository has pre-existing failures on
maininsend,paymentSuccess,home.pullToRefresh,WalletResetConfirmModal, andvault. This branch does not change any of them.Notes
No behavioural change to
walletStore; the persistence and re-show logic it already had is unchanged, now documented and covered.