Skip to content

Harden secure wallet storage failure handling#285

Merged
El-swaggerito merged 1 commit into
Axionvera:mainfrom
comzzy-comzzy:fix/257-secure-storage-handling
Jul 23, 2026
Merged

Harden secure wallet storage failure handling#285
El-swaggerito merged 1 commit into
Axionvera:mainfrom
comzzy-comzzy:fix/257-secure-storage-handling

Conversation

@comzzy-comzzy

Copy link
Copy Markdown
Contributor

Summary

  • centralize safe secure-storage error messages and recovery guidance
  • validate and sanitize wallet secrets on every secure-store read before returning them
  • update wallet save, import, export, send, review, vault, signer, and reset flows to avoid crashes or vague secret-key errors
  • add focused coverage for malformed stored secrets during secret-key access

Tests

  • npm test -- --runInBand tests/walletStore.test.ts tests/walletStore.test.ts
  • npm run typecheck (fails: existing tsconfig customConditions requires moduleResolution node16/nodenext/bundler)

Closes #257

@El-swaggerito
El-swaggerito merged commit 69d4020 into Axionvera:main Jul 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve secure storage failure handling

2 participants