Skip to content

Made image in input menu section not open new page when clicked - #222

Open
Slippery-Chickenz wants to merge 4 commits into
Avogadro:mainfrom
Slippery-Chickenz:input-menu-unclickable
Open

Made image in input menu section not open new page when clicked#222
Slippery-Chickenz wants to merge 4 commits into
Avogadro:mainfrom
Slippery-Chickenz:input-menu-unclickable

Conversation

@Slippery-Chickenz

Copy link
Copy Markdown

Made the image on the input menu page (https://avogadro.cc/docs/menus/input-menu.html) not open a new tab when clicked on.

@brockdyer03 brockdyer03 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, I've been annoyed by this issue in the past so this is good to see.

Important to note that you can still open the images in a new tab through the right-click menu.

:align: center
:height: 400px
:class: dark-light
:class: dark-light unclickable-figure

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely isn't the only spot where this issue arises. If you have spare time to grep for {figure} and replace them everywhere that'd be much appreciated.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made another commit that hopefully resolves this for similar cases. Might have missed images that are defined in a different way.

@brockdyer03 brockdyer03 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you got a lot of them, but a few errors in a few spots.

:alt: Example of the Angle Properties Dialog
:align: center
:width: 49%
:class: dark-light

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you misclicked while copy+pasting unclickable-figure here.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops

:alt: Example of the Torsion Properties Dialog
:align: center
:width: 59%
:class: dark-light

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops

Comment thread source/docs/menus/analyze-menu.md Outdated
:align: center
:height: 300px
:class: only-light
:class: only-ligh unclickable-figuret

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops

Comment thread source/docs/menus/analyze-menu.md Outdated
:align: center
:height: 300px
:class: only-dark
:class: only-dar unclickable-figurek

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops

@brockdyer03 brockdyer03 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants