feat: support keyboard system modifiers - #691
Merged
Merged
Conversation
Signed-off-by: Dhruv Maniya <dhruvmaniya1998@gmail.com>
Member
|
Hi @iamdhrv , Thank you so much for the good work. I really appreciate it. Everything looks good, great job! I will mark the draft as ready for review and then merge it. |
nathanschmid08
marked this pull request as ready for review
July 29, 2026 17:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
.ctrl,.alt,.shift,.meta, and.cmdsystem-key modifiers@keydown.shift.enterhandlerWhy
EventBinder already filters named keys such as
.enter, but it had no way toexpress common keyboard shortcuts. Mapping modifiers to the standard event
flags keeps this logic local to the existing modifier pipeline and allows
system and named-key filters to compose.
Checks
node test/unit/eventModifiers.test.jsnpm run lint -- --quietnpm test: 69/71 test files passed; the two unrelated failures requirewriting user-level files outside the repository sandbox
Fixes #637