Skip to content

feat: support keyboard system modifiers - #691

Merged
nathanschmid08 merged 1 commit into
Avenx-JS:mainfrom
iamdhrv:agent/system-key-modifiers
Jul 29, 2026
Merged

feat: support keyboard system modifiers#691
nathanschmid08 merged 1 commit into
Avenx-JS:mainfrom
iamdhrv:agent/system-key-modifiers

Conversation

@iamdhrv

@iamdhrv iamdhrv commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Change

  • add .ctrl, .alt, .shift, .meta, and .cmd system-key modifiers
  • require every requested system modifier before dispatching the handler
  • cover positive and negative cases for each modifier
  • cover a chained @keydown.shift.enter handler

Why

EventBinder already filters named keys such as .enter, but it had no way to
express common keyboard shortcuts. Mapping modifiers to the standard event
flags keeps this logic local to the existing modifier pipeline and allows
system and named-key filters to compose.

Checks

  • node test/unit/eventModifiers.test.js
  • npm run lint -- --quiet
  • npm test: 69/71 test files passed; the two unrelated failures require
    writing user-level files outside the repository sandbox

Fixes #637

Signed-off-by: Dhruv Maniya <dhruvmaniya1998@gmail.com>
@nathanschmid08

Copy link
Copy Markdown
Member

Hi @iamdhrv , Thank you so much for the good work. I really appreciate it. Everything looks good, great job! I will mark the draft as ready for review and then merge it.
Thanks.

@nathanschmid08
nathanschmid08 marked this pull request as ready for review July 29, 2026 17:08
@nathanschmid08
nathanschmid08 merged commit 08576dc into Avenx-JS:main Jul 29, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Good First Issue: Support Keyboard System Modifier Keys in EventBinder

2 participants