Skip to content

Add missing implementation of ScrollToHorizontalOffset/ScrollToVerticalOffset #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
siegfriedpammer wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add missing implementation of ScrollToHorizontalOffset/ScrollToVerticalOffset #594

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88b3028
Add missing implementation of ScrollToHorizontalOffset/ScrollToVertic…
siegfriedpammer May 31, 2026
8a1b229
Add missing implementations for LineDown, LineUp, LineLeft, LineRight…
siegfriedpammer May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions src/AvaloniaEdit/TextEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,71 +711,71 @@ public void EndChange()
/// </summary>
public void LineDown()
{
//if (scrollViewer != null)
// scrollViewer.LineDown();
ApplyTemplate(); // ensure scrollViewer is created
ScrollViewer?.LineDown();
}

/// <summary>
/// Scrolls to the left.
/// </summary>
public void LineLeft()
{
//if (scrollViewer != null)
// scrollViewer.LineLeft();
ApplyTemplate(); // ensure scrollViewer is created
ScrollViewer?.LineLeft();
}

/// <summary>
/// Scrolls to the right.
/// </summary>
public void LineRight()
{
//if (scrollViewer != null)
// scrollViewer.LineRight();
ApplyTemplate(); // ensure scrollViewer is created
ScrollViewer?.LineRight();
}

/// <summary>
/// Scrolls one line up.
/// </summary>
public void LineUp()
{
//if (scrollViewer != null)
// scrollViewer.LineUp();
ApplyTemplate(); // ensure scrollViewer is created
ScrollViewer?.LineUp();
}

/// <summary>
/// Scrolls one page down.
/// </summary>
public void PageDown()
{
//if (scrollViewer != null)
// scrollViewer.PageDown();
ApplyTemplate(); // ensure scrollViewer is created
ScrollViewer?.PageDown();
}

/// <summary>
/// Scrolls one page up.
/// </summary>
public void PageUp()
{
//if (scrollViewer != null)
// scrollViewer.PageUp();
ApplyTemplate(); // ensure scrollViewer is created
ScrollViewer?.PageUp();
}

/// <summary>
/// Scrolls one page left.
/// </summary>
public void PageLeft()
{
//if (scrollViewer != null)
// scrollViewer.PageLeft();
ApplyTemplate(); // ensure scrollViewer is created
ScrollViewer?.PageLeft();
}

/// <summary>
/// Scrolls one page right.
/// </summary>
public void PageRight()
{
//if (scrollViewer != null)
// scrollViewer.PageRight();
ApplyTemplate(); // ensure scrollViewer is created
ScrollViewer?.PageRight();
}

/// <summary>
Expand Down Expand Up @@ -827,8 +827,8 @@ public void ScrollToHome()
public void ScrollToHorizontalOffset(double offset)
{
ApplyTemplate(); // ensure scrollViewer is created
//if (scrollViewer != null)
// scrollViewer.ScrollToHorizontalOffset(offset);
if (ScrollViewer is { } scrollViewer)
scrollViewer.Offset = scrollViewer.Offset.WithX(offset);
}

/// <summary>
Expand All @@ -837,8 +837,8 @@ public void ScrollToHorizontalOffset(double offset)
public void ScrollToVerticalOffset(double offset)
{
ApplyTemplate(); // ensure scrollViewer is created
//if (scrollViewer != null)
// scrollViewer.ScrollToVerticalOffset(offset);
if (ScrollViewer is { } scrollViewer)
scrollViewer.Offset = scrollViewer.Offset.WithY(offset);
}

/// <summary>
Expand Down