Build/element named packages - #816
Merged
Merged
Conversation
gregmartDOTin
requested review from
LauRoxx and
jordan-a-young
as code owners
October 23, 2025 20:46
Contributor
|
LauRoxx
reviewed
Oct 24, 2025
|
|
||
| // Spaces | ||
| export { | ||
| INITIAL_STATE, |
Contributor
There was a problem hiding this comment.
let me know if there's any exports you think we should get rid of or rename in the next major
Contributor
Author
There was a problem hiding this comment.
Yeah, there are a couple of vars like that you can remove. I just included them so this is not a breaking change.
LauRoxx
approved these changes
Oct 24, 2025
LauRoxx
left a comment
LauRoxx
left a comment
Contributor
There was a problem hiding this comment.
do we have plans to do this to the wildcards in the individual packages? or are the advantages of that minimal?
Contributor
Author
The advantages to that appear to be minimal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.