Repository navigation
Validate filename template placeholders in config - #98
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Unsupported filename placeholders such as
{banana}are accepted by configuration but fail later during rename planning.Root cause
validate_profile()only checked that the template was a non-empty string.Fix
Validate template syntax and supported placeholders at profile validation time using
string.Formatter. Supported fields remaintrack,artist,title,album,album_artist,disc,year,genre, andformat.Tests
Added coverage for all supported fields, unsupported fields, malformed syntax, nested unsupported fields, and existing config behavior.
Validation
Latest branch CI is green across Python 3.11, 3.12, 3.13, unittest, pytest, compileall, pip check, Ruff, and security.
Scope / non-goals
No sanitization, collision, rename execution, scanner, metadata, artwork, duplicate, SQLite, or operation-log changes.
Closes #97