fix(logger): remove timestamp from production log format - #396
Open
sjinks wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the src/logger module’s production log line formatting to omit the inline timestamp (since production log aggregation already provides timestamps), and adjusts unit tests accordingly.
Changes:
- Removed the timestamp prefix from production log output in
src/logger/index.ts. - Updated the production logging test assertion in
__tests__/logger.spec.tsto match the new output format.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/logger/index.ts |
Updates the production printf formatter to no longer prepend timestamp to log lines. |
__tests__/logger.spec.ts |
Updates the production log output regex to match the new timestamp-free format. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the logging format in the
src/loggermodule to remove timestamps from production log output. Production log lines will now omit the timestamp, resulting in a simpler and more consistent log structure.Logging format changes:
src/logger/index.tsno longer includes the timestamp in the output string; only theapp,app_type, and the JSON-encoded log object are included.__tests__/logger.spec.tsis updated to match the new log output format without the timestamp.Why
Production logs already have a timestamp. By removing the timestamp from the message itself, we make it easier to filter out uninteresting duplicate log lines.
Steps to Test
Unit tests have been updated.