Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Fixes #3364.
Markdown previews could render as a blank note when a search query was active. The preview is rendered into a detached element, but the search-highlighting TreeWalker started from its root element and treated that root as a text node. This caused a null
parentNodeerror before the rendered content could be copied back into the visible preview.Start the traversal at the first matching text node instead, and add a regression test covering search highlighting in a detached render target.
Forum report: https://forums.simplenote.com/forums/topic/markdown-preview-broken-during-find/#post-6679
Test
Reviewer reproduction:
Automated verification performed:
npx jest --config=./jest.config.js lib/note-detail/render-to-node.test.ts --runInBandnpm test— 24/24 suites passed; 168 tests passed and 1 skippednpm run lint— completed with 0 errors (32 existing warnings)Release
RELEASE-NOTES.mdwas updated with: