Markdown formatting applied even when markdown disabled

[hobocamp]

I don't usually use markdown for my notes, so I was surprised after upgrading to v2.26.0 that some markdown formatting is being applied automatically.

Given there is a specific option to turn markdown on or off, this feels like an oversight/regression? I guess I could live with it (or find another note app use).. the issue is many of my notes contain various unix commands/config files, which specifically use "#" as a code comment, and it's super distracting to see those lines now in a huge font.

Expected

With the Markdown option disabled, markdown formatting should not be applied

In v2.25.0 and below:

Observed

Limited markdown formatting is applied no matter what.

Same note in v2.26.0:

Reproduced

1. In the latest SimpleNote, add a note with any sorta markdown, like "# header", and see special formatting applied to that line. Click the "..." Actions button and make sure 'Markdown' is disabled.
2. Downgrade your SimpleNote to 2.25.0
3. That same note is now just plain formatted text (like it had been for every version before 2.26.0)

Where did you see the bug

• OS: Windows
• OS version: 11
• Simplenote app version: 2.26.0

[gunjanjaswal]

Opened #3408. It gates the decoration path on the note's markdown system tag (via a markdownEnabled flag on getMarkdownDecorations), and keeps the clear() unconditional so toggling Markdown off on an open note removes the stale decorations. Added a unit test for the disabled case.

[MikeRaffa]

I'm getting what (I think) is this issue when pasting a Wikipedia page title into Simplenote (with markdown off). It's pasting the text in a large, bold font with a preceding '#' character. Toggling the markdown checkbox on and off has no effect. Windows11/Firefox.

[gunjanjaswal]

For what it's worth, #3408 addresses the root of this: it only applies the markdown decorations when the note actually has markdown enabled, so a plain (markdown-off) note stops getting decorated. @MikeRaffa's paste case looks like the same underlying behavior, the decorations rendering regardless of the note's markdown flag. Happy to double-check the paste path specifically if that turns out to be a separate entry point.