Skip to content

馃悰 Fix bugs behavior for first release - #14

Merged
Michelprogram merged 2 commits into
devfrom
fix-prod
May 10, 2026
Merged

馃悰 Fix bugs behavior for first release#14
Michelprogram merged 2 commits into
devfrom
fix-prod

Conversation

@ets-dorian

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands the public API and documentation around parsing Photon packets by adding a top-level README, public hook registration methods on Parser, and exported type aliases for reliable messages. It also refactors internal reliable message type definitions into internal/types and adjusts hook emission for parsed commands/reliable payloads.

Changes:

  • Add README with usage examples and local development instructions.
  • Introduce public Parser hook registration methods for reliable message types (event/operation) and export Reliable type aliases.
  • Refactor reliable message type/header definitions into internal/types and wire reliable parsing to emit new event hooks; update command emission to use the fully-populated types.Command.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
types.go Exposes Reliable / ReliableV18 aliases for consumers.
README.md Adds project documentation, examples, and dev workflow notes.
parser.go Adds package/docs, public hook registration methods, and clarifies Parser API behavior.
parser_test.go Reorders imports (formatting-only change).
internal/types/hooks.go Extends sync hooks with an OnEvents dispatch map for reliable messages.
internal/types/command.go Centralizes reliable message Type, ReliableHeader, and Reliable definitions under internal/types.
internal/parameters/v18/accessor_scalars.go Changes import style (formatting-only change).
internal/hooks/hooks.go Initializes the new OnEvents hook map in NewHooks.
internal/command/reliable/reliable.go Switches to internal/types reliable definitions and emits reliable-message hooks after decode.
internal/command/command.go Adjusts command hook emission to pass the finalized types.Command (out).
.mise/config.toml Adds a validate task combining lint/format/test/build; normalizes format task indentation.

馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/command/reliable/reliable.go
Comment thread internal/types/command.go Outdated
Comment thread parser.go
Comment thread internal/parameters/v18/accessor_scalars.go Outdated
Comment thread parser_test.go Outdated
Comment thread internal/command/command.go Outdated
@Michelprogram
Michelprogram merged commit f33a99d into dev May 10, 2026
3 checks passed
@Michelprogram
Michelprogram deleted the fix-prod branch May 10, 2026 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants