馃悰 Fix bugs behavior for first release - #14
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands the public API and documentation around parsing Photon packets by adding a top-level README, public hook registration methods on Parser, and exported type aliases for reliable messages. It also refactors internal reliable message type definitions into internal/types and adjusts hook emission for parsed commands/reliable payloads.
Changes:
- Add README with usage examples and local development instructions.
- Introduce public
Parserhook registration methods for reliable message types (event/operation) and exportReliabletype aliases. - Refactor reliable message type/header definitions into
internal/typesand wire reliable parsing to emit new event hooks; update command emission to use the fully-populatedtypes.Command.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| types.go | Exposes Reliable / ReliableV18 aliases for consumers. |
| README.md | Adds project documentation, examples, and dev workflow notes. |
| parser.go | Adds package/docs, public hook registration methods, and clarifies Parser API behavior. |
| parser_test.go | Reorders imports (formatting-only change). |
| internal/types/hooks.go | Extends sync hooks with an OnEvents dispatch map for reliable messages. |
| internal/types/command.go | Centralizes reliable message Type, ReliableHeader, and Reliable definitions under internal/types. |
| internal/parameters/v18/accessor_scalars.go | Changes import style (formatting-only change). |
| internal/hooks/hooks.go | Initializes the new OnEvents hook map in NewHooks. |
| internal/command/reliable/reliable.go | Switches to internal/types reliable definitions and emits reliable-message hooks after decode. |
| internal/command/command.go | Adjusts command hook emission to pass the finalized types.Command (out). |
| .mise/config.toml | Adds a validate task combining lint/format/test/build; normalizes format task indentation. |
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.