Add optional context parameter to embedding-based grounding#29
Open
nicoloesch wants to merge 2 commits into
Open
Add optional context parameter to embedding-based grounding#29nicoloesch wants to merge 2 commits into
nicoloesch wants to merge 2 commits into
Conversation
gkennos
self-requested a review
July 15, 2026 06:45
gkennos
reviewed
Jul 15, 2026
Collaborator
Author
|
This now depends on AustralianCancerDataNetwork/omop-emb#46 to pass so it can be included nicely. |
nicoloesch
added
the
feature
nicoloesch
force-pushed
the
19-rag-context
branch
from
July 23, 2026 00:07
df4150c to
4500173
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ground_term()gains an optionalcontext: str | Noneparameter, folded into the text passed to the on-demand query embedding call, letting callers supply disambiguating context alongside the term being grounded. No change to existing callers that omit it.