Skip to content

Add vocabulary-grouped embedding counts and filtered concept-id enumeration#41

Merged
nicoloesch merged 1 commit into
mainfrom
26-embedding-catalogue
Jul 20, 2026
Merged

Add vocabulary-grouped embedding counts and filtered concept-id enumeration#41
nicoloesch merged 1 commit into
mainfrom
26-embedding-catalogue

Conversation

@nicoloesch

Copy link
Copy Markdown
Collaborator

Summary

Adds two functionalities:

  1. get_embedding_count_by_vocabulary()
  2. get_indexed_concept_ids(concept_filter)
    • thin, uncached passthrough to the existing DB-backed get_concept_ids_matching_filter
    • deliberately bypasses FAISSCache so results always reflect live DB state rather than a potentially stale index snapshot.
    • Lets a caller inspect what's actually indexed before choosing a model or query filter, mirroring omop-graph's get_vocabulary_catalogue.
    • Fixes Add get_indexed_concept_ids to enumerate concept_ids by filter #33

@nicoloesch

Copy link
Copy Markdown
Collaborator Author

Lint PR is failing because it is not adhering to our current CI/CD. Related to #39 and the decisions there.

@nicoloesch
nicoloesch requested a review from gkennos July 10, 2026 03:49
Comment thread src/omop_emb/interface.py
@gkennos
gkennos self-requested a review July 19, 2026 14:23
@nicoloesch nicoloesch added the feature New backwards-compatible functionality. MINOR: x.y+1.z label Jul 20, 2026
@nicoloesch
nicoloesch force-pushed the 26-embedding-catalogue branch from 144d3c6 to 667e5a9 Compare July 20, 2026 06:56
@nicoloesch
nicoloesch merged commit 5aaacb1 into main Jul 20, 2026
2 checks passed
@nicoloesch
nicoloesch deleted the 26-embedding-catalogue branch July 20, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New backwards-compatible functionality. MINOR: x.y+1.z

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add get_indexed_concept_ids to enumerate concept_ids by filter Add vocabulary/domain breakdown to embedding catalogue status

2 participants