Repository navigation
Document null return for SIMD levels the CPU doesn't support - #209
Merged
Merged
Conversation
With Auburn/FastSIMD#21, NewDispatchClass returns nullptr when an explicit maxFeatureSet is above the CPU's max feature set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Auburn/FastSIMD#21 changes
NewDispatchClassto returnnullptrwhen an explicitmaxFeatureSetis above the CPU's max feature set. Before, it created that level anyway, which hits illegal instructions on first use.FeatureSet::Max(~0uin the C API) still means the CPU's max.Changes
Doc comments only. These now say they return null when the CPU doesn't support
maxFeatureSet:New<T>andNewFromEncodedNodeTree(FastNoise.h)Metadata::CreateNode(Metadata.h)fnNewFromEncodedNodeTreeandfnNewFromMetadata(FastNoise_C.h)Merge together with the FastSIMD bump that includes Auburn/FastSIMD#21.