Repository navigation
Make verify_commitment Reject Revoked IPs #1144
Description
Labels: bug, ip-registry, security
Priority: High
Estimated Time: 45 minutes
Description:
verify_commitment (lib.rs ~L2644) checks only the Archived flag. A revoked IP still returns true for the correct secret and blinding factor, so downstream swap logic that relies on verification accepts a revoked commitment.
Tasks:
- Return
falsewhenrecord.revokedis set - Add a regression test for verify-after-revoke
- Document the behavior in
docs/commitment-scheme.md
Imported from the AtomicIp_130.md backlog (item 2).
Activity
emekaabraham666 commentedon Oct 15, 2026
@emekaabraham666 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @emekaabraham666 to this issue.
drips-wave commentedon Oct 16, 2026
Congratulations, @emekaabraham666! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.
🧑💻 @emekaabraham666: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
fix(ip-registry): reject revoked IPs in verify_commitment (#1144)
grantfox-oss commentedon Oct 21, 2026
🎉 This issue has been marked as completed on GrantFox!
@emekaabraham666's PR #1274 was approved and merged by @fejilaup-cloud.
🏆 @emekaabraham666: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (624 total points). Track your full progress on GrantFox.
👏 Great work, @emekaabraham666! Keep contributing to AtomicIP.
drips-wave commentedon Oct 21, 2026
This issue has been completed by @emekaabraham666 as part of the Stellar Wave Program's 10th Wave 🥳
😎 @emekaabraham666: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.
fix(ip-registry): reject revoked IPs in verify_commitment (AtomicIP#1144