fix(browser): gate non-http(s) URLs in browser.tabs new#30
Open
Bartok9 wants to merge 1 commit into
Open
Conversation
Mirror browser.navigate approval for tabs action=new so file://, javascript:, and other non-http(s) schemes cannot open a secondary tab without the operator gate. Closes the bypass surface verified on main. Signed-off-by: Bartok9 <danielrpike9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browser.tabsaction: "new"the same way asbrowser.navigate: non-http(s)schemes require operator approval viaisSafeUrl+requireApproval.file:///javascript:/data:/ etc. from opening in a secondary tab without the approval gate.Motivation
Closes #29.
browser.navigatealready blocks dangerous schemes behind the approval gate.browser.tabswithaction: "new"+ aurlskipped that check and forwarded straight intopage.goto, so a model could open local files or script URLs through a second tool path. This mirrors the navigate contract at the tool layer (no Playwright backend behaviour change).Verification
npx vitest run src/tools/browser/browser-tools.test.ts— 32 passedtabs new+ https does not request approvaltabs new+file://→ApprovalDeniedError, backend never calledtabs new+javascript:→ sametabs listnever hits the URL gateCommit
Signed-off-by: Bartok9 <danielrpike9@gmail.com>)Agent-Owner:
sera· Platform: hermes · Claim-TTL: 24h