Skip to content

Normalize server address in Nacos config fetch function #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abu0306 merged 1 commit into from
Mar 10, 2026
Merged

Normalize server address in Nacos config fetch function #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/server/nacos.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ export async function fetchNacosConfig(): Promise<void> {
console.log('[nacos] NACOS_ENDPOINT not set, skipping Nacos config fetch')
return
}
const normalizedServerAddr = /^http/i.test(serverAddr)
? serverAddr
: `http://${serverAddr}`

const namespace = process.env.NACOS_NAMESPACE || 'public'
const dataId = process.env.NACOS_DATA_ID || '.env'
Expand All @@ -76,7 +79,7 @@ export async function fetchNacosConfig(): Promise<void> {
// Authenticate if credentials are provided
let accessToken: string | undefined
if (username && password) {
accessToken = await getAccessToken(serverAddr, username, password)
accessToken = await getAccessToken(normalizedServerAddr, username, password)
}

// Build config request URL
Expand All @@ -89,7 +92,7 @@ export async function fetchNacosConfig(): Promise<void> {
params.set('accessToken', accessToken)
}

const url = `${serverAddr}/nacos/v1/cs/configs?${params.toString()}`
const url = `${normalizedServerAddr}/nacos/v1/cs/configs?${params.toString()}`
const res = await fetch(url)

if (!res.ok) {
Expand All @@ -113,7 +116,7 @@ export async function fetchNacosConfig(): Promise<void> {
console.log(`ENVIRONMENT=${process.env.ENVIRONMENT ?? 'not set'}`)
} catch (err) {
console.warn(
`[nacos] Failed to fetch config from ${serverAddr} — falling back to env vars:`,
`[nacos] Failed to fetch config from ${normalizedServerAddr} — falling back to env vars:`,
err instanceof Error ? err.message : err,
)
}
Expand Down