Conversation
Contributor
|
The dynamic memory allocation is a little bit concerning to me. I'd suggest it be converted over to static allocation, but I suspect it's dynamic to avoid using the memory when the UART mitm is disabled. For that matter though, I do wonder if a uart mitm really belongs upstream? It seems kindof a niche debugging tool to me. If upstreamed at all, it probably belongs behind a compile-time enable. |
Collaborator
Author
|
The dynamic allocs are only done when uart.mitm is enabled via the setting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds uart_mitm, for logging uart bluetooth HCI traffic.