Upgrade @primer/css from v19 to v20 - #158
Merged
Merged
Conversation
Upgrade to the latest stable v20 release. v20 introduces global focus style improvements (outline-based instead of box-shadow) but has no class name removals or renames that affect this project. v21+ was intentionally skipped because it moves component CSS (Box, btn, etc.) to @primer/view-components (a Rails-oriented package), requiring an extra dependency. v22 removes these components entirely. v20.8.3 is the last version that ships all 29 Primer classes used in this project without additional dependencies. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Next.js updated the generated route types import path from .next/types/routes.d.ts to .next/dev/types/routes.d.ts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades Primer CSS to v20 and aligns Next.js generated route-type references to the updated .next output structure.
Changes:
- Bump
@primer/cssfrom^19.8.2to^20.8.3. - Update
package-lock.jsonto reflect the new dependency graph for Primer v20. - Update
next-env.d.tsto reference the new generated routes types path.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates @primer/css dependency to v20.8.3. |
| package-lock.json | Locks updated Primer v20 transitive dependencies (including new packages). |
| next-env.d.ts | Adjusts the generated routes type import path under .next/dev/types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@primer/cssfrom v19.8.2 to v20.8.3 (latest stable v20)next-env.d.tstypes pathAnalysis
Investigated upgrade path through v20 → v21 → v22. v20.8.3 is the optimal target for this project:
@primer/view-components(Rails package, +3.3MB extra dep)Box,Box-header,Box-body,Box-row,btn,btn-outlineremoved entirelyVerification
npm run build— compiled successfully (Turbopack)npm test— 23/23 tests passednpm run lint— no errorsTest plan
🤖 Generated with Claude Code