Add jiti to devDependencies for ESLint TS config - #157
Merged
Conversation
Bumps the dependencies group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | [marked](https://github.com/markedjs/marked) | `17.0.1` | `17.0.2` | | [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `25.2.2` | `25.2.3` | | [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) | `19.2.13` | `19.2.14` | | [@vitejs/plugin-react](https://github.com/vitejs/vite-plugin-react/tree/HEAD/packages/plugin-react) | `5.1.3` | `5.1.4` | | [jsdom](https://github.com/jsdom/jsdom) | `28.0.0` | `28.1.0` | Updates `marked` from 17.0.1 to 17.0.2 - [Release notes](https://github.com/markedjs/marked/releases) - [Commits](markedjs/marked@v17.0.1...v17.0.2) Updates `@types/node` from 25.2.2 to 25.2.3 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Updates `@types/react` from 19.2.13 to 19.2.14 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) Updates `@vitejs/plugin-react` from 5.1.3 to 5.1.4 - [Release notes](https://github.com/vitejs/vite-plugin-react/releases) - [Changelog](https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite-plugin-react/commits/plugin-react@5.1.4/packages/plugin-react) Updates `jsdom` from 28.0.0 to 28.1.0 - [Release notes](https://github.com/jsdom/jsdom/releases) - [Changelog](https://github.com/jsdom/jsdom/blob/main/Changelog.md) - [Commits](jsdom/jsdom@28.0.0...28.1.0) --- updated-dependencies: - dependency-name: marked dependency-version: 17.0.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: "@types/node" dependency-version: 25.2.3 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: "@types/react" dependency-version: 19.2.14 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: "@vitejs/plugin-react" dependency-version: 5.1.4 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: jsdom dependency-version: 28.1.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
ESLint 9 requires jiti to load TypeScript configuration files. The dependency was dropped during the Dependabot update, causing CI eslint scanning to fail. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores ESLint’s ability to load the TypeScript flat config (eslint.config.ts) in CI by explicitly adding jiti as a devDependency, after it was dropped from the dependency tree during prior dependency bumps.
Changes:
- Add
jititodevDependenciesto satisfy ESLint’s optional peer dependency needed for loadingeslint.config.ts. - Update several dependencies/devDependencies versions (e.g.,
marked,@types/node,@types/react,@vitejs/plugin-react,jsdom) and refreshpackage-lock.jsonaccordingly.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Adds jiti to devDependencies and updates a handful of package versions. |
| package-lock.json | Locks jiti as a direct dev dependency and incorporates the dependency tree updates from the version bumps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
35
to
+44
| "@types/eslint": "^9.6.1", | ||
| "@types/node": "^25.2.2", | ||
| "@types/react": "^19.2.13", | ||
| "@types/node": "^25.2.3", | ||
| "@types/react": "^19.2.14", | ||
| "@types/sanitize-html": "^2.16.0", | ||
| "@vitejs/plugin-react": "^5.1.3", | ||
| "@vitejs/plugin-react": "^5.1.4", | ||
| "@vitest/coverage-v8": "^4.0.18", | ||
| "eslint": "^9.39.2", | ||
| "eslint-config-next": "^16.1.6", | ||
| "jsdom": "^28.0.0", | ||
| "jiti": "^2.6.1", | ||
| "jsdom": "^28.1.0", |
There was a problem hiding this comment.
The PR title/description focuses on adding jiti, but this change set also bumps several packages (e.g., marked, @types/node/@types/react, @vitejs/plugin-react, jsdom). Please update the PR title/description to reflect that it also replaces the dependency bump PR (#156), or split the dependency version bumps into a separate PR to keep review scope clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jitiがpackage-lock.jsonから落ち、ESLint が TypeScript 設定ファイルを読み込めず CI が失敗していたjitiをdevDependenciesに明示的に追加して解決Context
ESLint 9 は TypeScript 設定ファイル (
eslint.config.ts) の読み込みにjitiを必要とする。以前は間接的な依存として含まれていたが、#156 の更新で依存ツリーから外れた。Closes #156 を置き換える形でマージ可能。
Test plan
🤖 Generated with Claude Code