test(hf-hub): batch-3 private repo and auth correctness - #27
Merged
Conversation
Mark batch 2 as complete in the roadmap and checklist, move the active pointer to batch 3, and link the new auth/visibility tracking issue so the next slice starts from the merged mainline state. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Align batch-3 Hub behavior with huggingface_hub expectations by hiding private repos from anonymous reads, forbidding authenticated non-owner access, and rejecting non-owner writes to protected repos. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Keep the roadmap and checklist aligned with the active compatibility workflow by recording the live batch-3 pull request alongside the existing issue link. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Apply the CI-required rustfmt wrapping in the batch-3 auth helper module so the unit workflow can validate the branch cleanly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
huggingface_hubcompatibility rollout for private repo visibility and auth correctnesstoken=Falsebehavior, and one narrow non-owner mutation boundaryTest plan
HF_ENDPOINT=http://localhost:8080 uv run --with pytest --with huggingface_hub --with requests pytest tests/integration/hf_hub/test_auth_batch3.py -qHF_ENDPOINT=http://localhost:8080 uv run --with pytest --with huggingface_hub --with requests pytest tests/integration/hf_hub/test_repo_visibility_batch3.py -qHF_ENDPOINT=http://localhost:8080 uv run --with pytest --with huggingface_hub --with requests pytest tests/integration/hf_hub -qHF_ENDPOINT=http://localhost:8080 uv run tests/integration/test_downloads.pyCloses #26
馃 Generated with Claude Code