merge by Aswanidev-vs · Pull Request #32 · Aswanidev-vs/Predator

Aswanidev-vs · 2026-03-20T18:44:40Z

No description provided.

fix the new issue for the codec of webm and mp4 and m4a

V7

backup

fix the playlist issue and related issues

ignore

backup

coderabbitai · 2026-03-20T18:44:47Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1299eca4-9cca-4916-8dac-f2a1544d30fe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch v5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can customize the tone of the review comments and chat replies.

Configure the tone_instructions setting to customize the tone of the review comments and chat replies. For example, you can set the tone to Act like a strict teacher, Act like a pirate and more.

gemini-code-assist · 2026-03-20T18:46:07Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the user experience and maintainability of the Predator application. It includes a comprehensive update to the README, detailing features and usage, enhancements to video/audio format selection logic, and the addition of a contributing guide.

Highlights

README Update: The README.md file was significantly updated to provide a more comprehensive overview of the Predator application, including features, usage instructions, technical details, troubleshooting, and legal disclaimers.
Format String Improvements: The format string logic in app.go was enhanced to improve video and audio quality selection, particularly for MP4 and WebM containers, ensuring better codec handling and compatibility.
Contributing Guide: A new CONTRIBUTING.md file was added to provide guidelines for contributing to the project, including submodule management and development quickstart instructions.

Ignored Files

Ignored by pattern: .github/workflows/** (1)
- .github/workflows/submodule-check.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request appears to be a merge of a feature branch, which includes a major refactoring from the Fyne framework to Wails. The README.md has been significantly improved and a CONTRIBUTING.md file has been added. The download logic in app.go has been made more robust with better format selection fallbacks.

My review includes a few suggestions:

In README.md, there are some inconsistencies regarding the required Go version and a broken link in the table of contents.
In app.go, I've identified an unused function parameter, some duplicated code that can be refactored, and a new function that seems to be dead code.

Overall, these are great improvements to the project's structure and functionality. Addressing these points will enhance code quality and documentation clarity.

gemini-code-assist · 2026-03-20T18:47:35Z

+func buildWebmFormatString(cleanRes string) string {
+	// For webm, we want VP9 or AV1 video with opus audio
+	// This provides better quality than older vp8/opus combinations
+
+	if cleanRes == "best" {
+		// Best quality webm - prioritize av01 (AV1) then vp9
+		return "bestvideo[vcodec^=av01]+bestaudio[acodec^=opus]/" +
+			"bestvideo[vcodec^=av01]+bestaudio[ext=webm]/" +
+			"bestvideo[vcodec^=av01]+bestaudio/" +
+			"bestvideo[vcodec^=vp9]+bestaudio[acodec^=opus]/" +
+			"bestvideo[vcodec^=vp9]+bestaudio[ext=webm]/" +
+			"bestvideo[vcodec^=vp9]+bestaudio/" +
+			"bestvideo[vcodec^=vp8]+bestaudio[acodec^=opus]/" +
+			"bestvideo[vcodec^=vp8]+bestaudio/" +
+			"bestvideo+bestaudio[acodec^=opus]/bestvideo+bestaudio/best"
+	}
+
+	resNum, _ := strconv.Atoi(cleanRes)
+	if resNum >= 1440 {
+		// High resolutions - prioritize av01 then vp9
+		return fmt.Sprintf(
+			// AV1 with opus - best quality
+			"bestvideo[vcodec^=av01][height=%s]+bestaudio[acodec^=opus]/"+
+				"bestvideo[vcodec^=av01][height=%s]+bestaudio[ext=webm]/"+
+				"bestvideo[vcodec^=av01][height=%s]+bestaudio/"+
+				// AV1 <= height fallback
+				"bestvideo[vcodec^=av01][height<=%s]+bestaudio[acodec^=opus]/"+
+				"bestvideo[vcodec^=av01][height<=%s]+bestaudio[ext=webm]/"+
+				"bestvideo[vcodec^=av01][height<=%s]+bestaudio/"+
+				// VP9 with opus
+				"bestvideo[vcodec^=vp9][height=%s]+bestaudio[acodec^=opus]/"+
+				"bestvideo[vcodec^=vp9][height=%s]+bestaudio[ext=webm]/"+
+				"bestvideo[vcodec^=vp9][height=%s]+bestaudio/"+
+				// VP9 <= height fallback
+				"bestvideo[vcodec^=vp9][height<=%s]+bestaudio[acodec^=opus]/"+
+				"bestvideo[vcodec^=vp9][height<=%s]+bestaudio[ext=webm]/"+
+				"bestvideo[vcodec^=vp9][height<=%s]+bestaudio/"+
+				// Any codec fallback
+				"bestvideo[height<=%s]+bestaudio[acodec^=opus]/"+
+				"bestvideo[height<=%s]+bestaudio[ext=webm]/"+
+				"bestvideo[height<=%s]+bestaudio/"+
+				"best[height<=%s]",
+			cleanRes, cleanRes, cleanRes, cleanRes, cleanRes, cleanRes,
+			cleanRes, cleanRes, cleanRes, cleanRes, cleanRes, cleanRes,
+			cleanRes, cleanRes, cleanRes, cleanRes,
+		)
+	}
+
+	// Standard resolutions - prioritize av01 then vp9 with opus
+	return fmt.Sprintf(
+		// AV1 with opus
+		"bestvideo[vcodec^=av01][height=%s]+bestaudio[acodec^=opus]/"+
+			"bestvideo[vcodec^=av01][height=%s]+bestaudio[ext=webm]/"+
+			"bestvideo[vcodec^=av01][height=%s]+bestaudio/"+
+			// AV1 <= height fallback
+			"bestvideo[vcodec^=av01][height<=%s]+bestaudio[acodec^=opus]/"+
+			"bestvideo[vcodec^=av01][height<=%s]+bestaudio[ext=webm]/"+
+			"bestvideo[vcodec^=av01][height<=%s]+bestaudio/"+
+			// VP9 with opus
+			"bestvideo[vcodec^=vp9][height=%s]+bestaudio[acodec^=opus]/"+
+			"bestvideo[vcodec^=vp9][height=%s]+bestaudio[ext=webm]/"+
+			"bestvideo[vcodec^=vp9][height=%s]+bestaudio/"+
+			// VP9 <= height fallback
+			"bestvideo[vcodec^=vp9][height<=%s]+bestaudio[acodec^=opus]/"+
+			"bestvideo[vcodec^=vp9][height<=%s]+bestaudio[ext=webm]/"+
+			"bestvideo[vcodec^=vp9][height<=%s]+bestaudio/"+
+			// Any codec fallback
+			"bestvideo[height<=%s]+bestaudio[acodec^=opus]/"+
+			"bestvideo[height<=%s]+bestaudio[ext=webm]/"+
+			"bestvideo[height<=%s]+bestaudio/"+
 			"best[height<=%s]",
 		cleanRes, cleanRes, cleanRes, cleanRes, cleanRes, cleanRes,
 		cleanRes, cleanRes, cleanRes, cleanRes, cleanRes, cleanRes,
-		cleanRes, cleanRes, cleanRes,
+		cleanRes, cleanRes, cleanRes, cleanRes,
 	)
 }


The function buildWebmFormatString is defined but it's not used anywhere in the codebase. This appears to be dead code. Please either use it or remove it to avoid confusion and reduce maintenance overhead.

gemini-code-assist · 2026-03-20T18:47:35Z

+- [Features](#features)
+- [Getting Started](#getting-started)
+- [How to Use](#how-to-use)
+- [Keyboard Shortcuts](#keyboard-shortcuts)


The Table of Contents includes a link to Keyboard Shortcuts, but there is no corresponding section in the document. This is a broken link. Please either add the section or remove the link from the table of contents.

gemini-code-assist · 2026-03-20T18:47:35Z

+## Getting Started

-## Installation
+You'll need **Go 1.24 or newer** installed.


The go.mod and CONTRIBUTING.md files specify Go version 1.25, but this file mentions 1.24 or newer. For consistency, it would be better to update this to 1.25 or newer.

Suggested change

You'll need **Go 1.24 or newer** installed.

You'll need **Go 1.25 or newer** installed.

gemini-code-assist · 2026-03-20T18:47:35Z


+// buildVideoFormatString builds format string for mp4 container with proper codec handling
+// Uses separate video+audio selection to ensure reliable merging
 func buildVideoFormatString(cleanRes string, preferH264 bool) string {


The preferH264 parameter is declared but not used within the function. The logic already prioritizes H.264 (avc1). This parameter should be removed to simplify the function signature. Remember to update the call site at app.go:1600 as well.

gemini-code-assist · 2026-03-20T18:47:35Z

 	resNum, _ := strconv.Atoi(cleanRes)
 	if resNum >= 1440 {
-		// High resolutions - try exact height first, then fall back to <=
-		// STRICTLY m4a audio only to prevent ffmpeg merge failures
+		// High resolutions (1440p+) - prioritize h264 with exact or close height match
 		return fmt.Sprintf(
-			// Try exact height match first with m4a audio only
+			// h264 with m4a audio - best for mp4 merging
 			"bestvideo[vcodec^=avc1][height=%s]+bestaudio[ext=m4a]/"+
 				"bestvideo[vcodec^=avc1][height=%s]+bestaudio[acodec^=mp4a]/"+
+				"bestvideo[vcodec^=avc1][height=%s]+bestaudio/"+
+				// h264 with <= height fallback
+				"bestvideo[vcodec^=avc1][height<=%s]+bestaudio[ext=m4a]/"+
+				"bestvideo[vcodec^=avc1][height<=%s]+bestaudio[acodec^=mp4a]/"+
+				"bestvideo[vcodec^=avc1][height<=%s]+bestaudio/"+
+				// vp9 fallback
 				"bestvideo[vcodec^=vp9][height=%s]+bestaudio[ext=m4a]/"+
 				"bestvideo[vcodec^=vp9][height=%s]+bestaudio[acodec^=mp4a]/"+
+				"bestvideo[vcodec^=vp9][height=%s]+bestaudio/"+
+				// av1 fallback
 				"bestvideo[vcodec^=av01][height=%s]+bestaudio[ext=m4a]/"+
 				"bestvideo[vcodec^=av01][height=%s]+bestaudio[acodec^=mp4a]/"+
-				// Fall back to <= if exact match not available - still m4a only
-				"bestvideo[vcodec^=avc1][height<=%s]+bestaudio[ext=m4a]/"+
-				"bestvideo[vcodec^=avc1][height<=%s]+bestaudio[acodec^=mp4a]/"+
-				"bestvideo[vcodec^=vp9][height<=%s]+bestaudio[ext=m4a]/"+
-				"bestvideo[vcodec^=vp9][height<=%s]+bestaudio[acodec^=mp4a]/"+
-				"bestvideo[vcodec^=av01][height<=%s]+bestaudio[ext=m4a]/"+
-				"bestvideo[vcodec^=av01][height<=%s]+bestaudio[acodec^=mp4a]/"+
-				// Final fallbacks - still prefer m4a
+				"bestvideo[vcodec^=av01][height=%s]+bestaudio/"+
+				// Any video codec fallback
 				"bestvideo[height<=%s]+bestaudio[ext=m4a]/"+
 				"bestvideo[height<=%s]+bestaudio[acodec^=mp4a]/"+
+				"bestvideo[height<=%s]+bestaudio/"+
 				"best[height<=%s]",
 			cleanRes, cleanRes, cleanRes, cleanRes, cleanRes, cleanRes,
 			cleanRes, cleanRes, cleanRes, cleanRes, cleanRes, cleanRes,
-			cleanRes, cleanRes, cleanRes,
+			cleanRes, cleanRes, cleanRes, cleanRes,
 		)
 	}

-	// Standard resolutions - try exact height first, then fall back
-	// STRICTLY m4a audio only to prevent ffmpeg merge failures
+	// Standard resolutions - prioritize h264 with m4a audio
 	return fmt.Sprintf(
-		// Try exact height match first with m4a audio only
+		// h264 with m4a audio - best for mp4 merging
 		"bestvideo[vcodec^=avc1][height=%s]+bestaudio[ext=m4a]/"+
 			"bestvideo[vcodec^=avc1][height=%s]+bestaudio[acodec^=mp4a]/"+
+			"bestvideo[vcodec^=avc1][height=%s]+bestaudio/"+
+			// h264 with <= height fallback
+			"bestvideo[vcodec^=avc1][height<=%s]+bestaudio[ext=m4a]/"+
+			"bestvideo[vcodec^=avc1][height<=%s]+bestaudio[acodec^=mp4a]/"+
+			"bestvideo[vcodec^=avc1][height<=%s]+bestaudio/"+
+			// vp9 fallback
 			"bestvideo[vcodec^=vp9][height=%s]+bestaudio[ext=m4a]/"+
 			"bestvideo[vcodec^=vp9][height=%s]+bestaudio[acodec^=mp4a]/"+
+			"bestvideo[vcodec^=vp9][height=%s]+bestaudio/"+
+			// av1 fallback
 			"bestvideo[vcodec^=av01][height=%s]+bestaudio[ext=m4a]/"+
 			"bestvideo[vcodec^=av01][height=%s]+bestaudio[acodec^=mp4a]/"+
-			// Fall back to <= if exact match not available - still m4a only
-			"bestvideo[vcodec^=avc1][height<=%s]+bestaudio[ext=m4a]/"+
-			"bestvideo[vcodec^=avc1][height<=%s]+bestaudio[acodec^=mp4a]/"+
-			"bestvideo[vcodec^=vp9][height<=%s]+bestaudio[ext=m4a]/"+
-			"bestvideo[vcodec^=vp9][height<=%s]+bestaudio[acodec^=mp4a]/"+
-			"bestvideo[vcodec^=av01][height<=%s]+bestaudio[ext=m4a]/"+
-			"bestvideo[vcodec^=av01][height<=%s]+bestaudio[acodec^=mp4a]/"+
-			// Final fallbacks - still prefer m4a
+			"bestvideo[vcodec^=av01][height=%s]+bestaudio/"+
+			// Any video codec fallback
 			"bestvideo[height<=%s]+bestaudio[ext=m4a]/"+
 			"bestvideo[height<=%s]+bestaudio[acodec^=mp4a]/"+
+			"bestvideo[height<=%s]+bestaudio/"+
+			"best[height<=%s]",
+		cleanRes, cleanRes, cleanRes, cleanRes, cleanRes, cleanRes,
+		cleanRes, cleanRes, cleanRes, cleanRes, cleanRes, cleanRes,
+		cleanRes, cleanRes, cleanRes, cleanRes,
+	)


The code blocks for high resolutions (>= 1440p) and standard resolutions are identical. This duplication can be removed by merging them into a single block, which will make the code more maintainable.

// The logic for all resolutions is the same, so no need for the if/else block. // Standard resolutions - prioritize h264 with m4a audio return fmt.Sprintf( // h264 with m4a audio - best for mp4 merging "bestvideo[vcodec^=avc1][height=%s]+bestaudio[ext=m4a]/"+ "bestvideo[vcodec^=avc1][height=%s]+bestaudio[acodec^=mp4a]/"+ "bestvideo[vcodec^=avc1][height=%s]+bestaudio/"+ // h264 with <= height fallback "bestvideo[vcodec^=avc1][height<=%s]+bestaudio[ext=m4a]/"+ "bestvideo[vcodec^=avc1][height<=%s]+bestaudio[acodec^=mp4a]/"+ "bestvideo[vcodec^=avc1][height<=%s]+bestaudio/"+ // vp9 fallback "bestvideo[vcodec^=vp9][height=%s]+bestaudio[ext=m4a]/"+ "bestvideo[vcodec^=vp9][height=%s]+bestaudio[acodec^=mp4a]/"+ "bestvideo[vcodec^=vp9][height=%s]+bestaudio/"+ // av1 fallback "bestvideo[vcodec^=av01][height=%s]+bestaudio[ext=m4a]/"+ "bestvideo[vcodec^=av01][height=%s]+bestaudio[acodec^=mp4a]/"+ "bestvideo[vcodec^=av01][height=%s]+bestaudio/"+ // Any video codec fallback "bestvideo[height<=%s]+bestaudio[ext=m4a]/"+ "bestvideo[height<=%s]+bestaudio[acodec^=mp4a]/"+ "bestvideo[height<=%s]+bestaudio/"+ "best[height<=%s]", cleanRes, cleanRes, cleanRes, cleanRes, cleanRes, cleanRes, cleanRes, cleanRes, cleanRes, cleanRes, cleanRes, cleanRes, cleanRes, cleanRes, cleanRes, cleanRes, )

Aswanidev-vs added 17 commits March 5, 2026 18:36

fix the new issue for the codec of webm and mp4 and m4a

8b580a4

Merge pull request #22 from Aswanidev-vs/v7

9eca935

fix the new issue for the codec of webm and mp4 and m4a

improve readme.md

dcc58e8

improve readme.md

7cc915d

Merge branch 'v5' into v7

97ebe0d

Merge pull request #23 from Aswanidev-vs/v7

357a617

V7

backup

d9e2132

Merge pull request #25 from Aswanidev-vs/v9

90676bd

backup

Update README.md

f7e2b02

fix the playlist issue and related issues

30cbc54

backup code

a3e8e70

Merge branch 'v5' into v9-new

d08c2c2

Merge pull request #28 from Aswanidev-vs/v9-new

dd7c2d9

fix the playlist issue and related issues

ignore

f7f06e1

Merge pull request #29 from Aswanidev-vs/v9

cf9442c

ignore

backup

07ec0f8

Merge pull request #31 from Aswanidev-vs/v9

a59fdfa

backup

Aswanidev-vs merged commit 4e2e4bc into wails Mar 20, 2026
7 of 10 checks passed

gemini-code-assist Bot reviewed Mar 20, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

merge#32

merge#32
Aswanidev-vs merged 17 commits into
wailsfrom
v5

Aswanidev-vs commented Mar 20, 2026

Uh oh!

coderabbitai Bot commented Mar 20, 2026

Review skipped

Uh oh!

Uh oh!

gemini-code-assist Bot commented Mar 20, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Mar 20, 2026

Uh oh!

gemini-code-assist Bot Mar 20, 2026

Uh oh!

gemini-code-assist Bot Mar 20, 2026

Uh oh!

gemini-code-assist Bot Mar 20, 2026

Uh oh!

gemini-code-assist Bot Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	You'll need Go 1.24 or newer installed.
	You'll need Go 1.25 or newer installed.

Conversation

Aswanidev-vs commented Mar 20, 2026

Uh oh!

coderabbitai Bot commented Mar 20, 2026

Review skipped

Uh oh!

Uh oh!

gemini-code-assist Bot commented Mar 20, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant