[fix](distributed) Disable insecure Flight transport by default - #233
Open
QuakeWang wants to merge 3 commits into
Open
[fix](distributed) Disable insecure Flight transport by default#233QuakeWang wants to merge 3 commits into
QuakeWang wants to merge 3 commits into
Conversation
Local-disk shuffle started and published a process-wide plaintext Flight listener by default even though it binds to 0.0.0.0 without TLS or client authentication. Require an explicit development opt-in, serialize it with exchange plans, and keep same-process and object-storage shuffle network-free. Reject remote local-disk reads before connecting when the opt-in is absent. Refs AstroVela#57 Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b08c9085a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The insecure Flight opt-in is serialized with exchange plans, so existing Ray workers do not need to be recreated. Align the public documentation, configuration help, and runtime errors with that plan-scoped behavior. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
Contributor
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Local-disk shuffle previously started and published a process-wide plaintext Arrow Flight listener on
0.0.0.0by default, without TLS or client authentication.This PR disables that transport by default. It adds an explicit development opt-in, serializes the decision with exchange plans, prevents disabled plans from publishing process-global endpoints, and rejects remote local-disk reads before connecting. Same-process and object-storage shuffle remain network-free.
Related issue
Refs #57
Documentation impact
AstroVela/vane-website.Validation
scripts/format workspace --changedpre-commit run --from-ref upstream/main --to-ref HEADpython -m pytest tests/fast/test_vane_config.py— 40 passedscripts/run_release_tests.sh— 438 passed, 1 skippedChecklist
licenses and are recorded where required.
weights, or build artifacts are included.
and untrusted input have been considered.
changes passed relevant checks.