Skip to content

Withdraw CloudFront private image delivery - #311

Closed
mintuhouse wants to merge 9 commits into
mainfrom
mintuhouse/cloudfront-private-files
Closed

mintuhouse wants to merge 9 commits into
mainfrom
mintuhouse/cloudfront-private-files

Conversation

@mintuhouse

@mintuhouse mintuhouse commented Oct 15, 2026 •

Copy link
Copy Markdown
Member
  • Rebase onto main 2f86dd1c1a5b06dc5e9177f7a2bc47d17b888ef7 and revert all CloudFront private image delivery changes at the user's request.
  • Restore the exact main source tree and native S3 behavior. Evaluate Cloudflare asset delivery separately.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T01:22:19.673229Z 7d86d8c New commits
🔒 Security Review ✅ Completed 2026-10-15T09:17:27.245582Z 40379ad PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mintuhouse

mintuhouse commented Oct 15, 2026 •

Copy link
Copy Markdown
Member Author

Withdrawal validation

PR #311 was withdrawn at the user's request and closed without merging.

Head: 7d86d8ce2039c1739327cf276e175572ba52f8bf. Rebased onto main 2f86dd1c1a5b06dc5e9177f7a2bc47d17b888ef7, then reverted all changes from this PR in one recorded commit.

  • Verified that the entire committed source tree is identical to main. Both Git tree IDs are 02c8d09091755e3f349e71736013aa50eac582b0. The final PR diff has zero changed files, additions or deletions.
  • Native S3 signing, uploads, downloads and current authorization behavior are main's unchanged implementation. Removed the proposed CloudFront signer, configuration fields, dependency, tests, documentation and PR-specific instruction.
  • Bun 1.4.4 setup, production build, compiled-binary smoke check and git diff --check passed. The binary check bootstrapped a fresh disposable test database, checked embedded migrations, asset/docs serving and clean shutdown, then removed the test database.
  • Hosted CI: all 11 current-head checks passed, including Platform checks, unit tests, integration tests, build and the other project checks.
Required local browser suites, run in parallel after push Result Duration
Platform default projects 14 passed, 0 failed, 0 flaky, 0 skipped 223.5s
Todos app 66 passed, 0 failed, 0 flaky, 0 skipped 154.7s
  • Platform report: /tmp/astralbeam-pr311-revert-20261029/7d86d8ce2039/platform/report/index.html.
  • Todos report: /tmp/astralbeam-pr311-revert-20261029/7d86d8ce2039/todos-app/report/index.html.
  • Reusing the existing task runners with the pinned Bun avoided the shell-version retry from the prior refresh. Net-zero tree verification proves no CloudFront feature remains proposed.
  • Existing AWS, CloudFront, Cloudflare and DNS infrastructure were not modified. This is a repository rollback, not an infrastructure teardown.
  • Cloudflare asset delivery remains research only. A Worker on the current authorized image routes could intercept their S3 redirect and proxy the private object, initially without caching or new signing code. Any future shared cache must authorize every request before looking up cached bytes. A separate custom hostname requires an explicit authentication handoff. No Worker was deployed.
  • A scratch Bun experiment passed two synthetic S3-signed URL roundtrips with encoded paths and queries restored exactly. It made no network requests and is not a deployed Cloudflare integration test.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
website-astralbeam-ai 7d86d8c Commit Preview URL

Branch Preview URL
Oct 29 2026, 01:22 AM

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 40379adc39

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread platform/src/lib/config/registry.ts Resolved
Comment thread platform/src/lib/config/registry.ts Resolved
Comment thread platform/src/lib/config/registry.ts Resolved

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 67d513b8c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread platform/src/lib/config/registry.ts Resolved
@mintuhouse mintuhouse changed the title Add private CloudFront image downloads Select S3 or CloudFront for private image downloads Oct 15, 2026
@mintuhouse
mintuhouse force-pushed the mintuhouse/cloudfront-private-files branch from 0f7c12d to f58a65f Compare October 17, 2026 18:45
@mintuhouse
mintuhouse force-pushed the mintuhouse/cloudfront-private-files branch from 7cde806 to 8dc03be Compare October 28, 2026 06:38
@mintuhouse
mintuhouse force-pushed the mintuhouse/cloudfront-private-files branch from 8dc03be to 7d86d8c Compare October 29, 2026 01:21
@mintuhouse mintuhouse changed the title Select S3 or CloudFront for private image downloads Withdraw CloudFront private image delivery Oct 29, 2026
@mintuhouse mintuhouse closed this Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant