Refactor Home theme initialization and persistence flow#8
Merged
TomChicken-on-github merged 1 commit intoFeb 24, 2026
Merged
Conversation
Deploying wsmcs with
|
| Latest commit: |
12a74db
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://238c546b.wsmcs.pages.dev |
| Branch Preview URL: | https://codex-refactor-theme-initial.wsmcs.pages.dev |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for wsmcs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
requestIdleCallbackonly for non-critical writes tolocalStoragewhile avoiding it for the first read/application of theme to eliminate race conditions.Description
isThemeInitialized(ref) and a new synchronousinitTheme()that readslocalStorage.getItem('theme')first, falls back tomatchMedia('(prefers-color-scheme: dark)'), setstheme.value, and togglesdocument.documentElement.classListin one place.watch(theme, ...)handler to removeimmediate: true, normalizeresolvedTheme, update thedarkclass immediately, and only persist tolocalStorageasynchronously whenisThemeInitializedis true usingrequestIdleCallback(with asetTimeoutfallback).initTheme()fromonMounted()and removed the previousrequestIdleCallback-based initial read path so initial read/apply is synchronous while writes remain deferred.Testing
npm run buildsuccessfully and the build completed without blocking errors (warnings from tooling reported but did not affect the build outcome).Codex Task