Expose voice-note metadata in receive JSON - #2100
Merged
Merged
Conversation
Include isVoiceNote in receive JSON and JSON-RPC attachment payloads. Add regression coverage for true and false serialization.
niieani
marked this pull request as ready for review
August 9, 2026 23:23
AsamK
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isVoiceNoteon attachment objects in JSON receive outputtrueandfalseprojection and serializationWhy
MessageEnvelope.Data.Attachmentalready retains the voice-note flag fromSignalServiceAttachment, and plain-text and D-Bus receive output already expose it.JsonAttachmentomitted the flag, forcing JSON consumers to infer voice notes from MIME type and message shape.This is an additive JSON field.
isGifandisBorderlessremain out of scope.Validation
./gradlew :test --tests org.asamk.signal.json.JsonAttachmentTest --rerun-tasks./gradlew build jsonSchemasattachment.schema.jsoncontains required booleanisVoiceNote