Support the GroupsV2 "end group" (terminate) feature - #2098
Merged
Conversation
FailSpy
force-pushed
the
feature/groupv2-terminate
branch
from
August 7, 2026 18:29
01b1c34 to
db847f1
Compare
AsamK
requested changes
Aug 8, 2026
AsamK
left a comment
Owner
There was a problem hiding this comment.
Thanks, looks good.
Just the naming is inconsistent, please use terminate instead of end everywhere
A group admin can permanently terminate a group. Afterwards the group is read-only for everyone, not even an admin can send messages or start calls; members keep access to the existing history. Other clients silently drop messages sent to a terminated group. Read the DecryptedGroup.terminated flag through GroupInfo.isTerminated() and: - surface it in listGroups (json and plain text) and as the DBus IsTerminated group property - refuse to send to a terminated group locally (messages, reactions, typing and group stories) rather than send one that other clients ignore - drop incoming messages addressed to a terminated group
Let a group admin permanently terminate a GroupV2 group via the TerminateGroupAction (Groups.proto field 28, change epoch 7) the pinned library already exposes as GroupsV2Operations.createTerminateGroup(). - GroupV2Helper.terminateGroup builds and commits the change - GroupHelper.terminateGroup resolves/refreshes the group (v2 only), sends the update to members and syncs storage, with the same conflict-retry as updateGroup - exposed through Manager.terminateGroup, the terminateGroup CLI/JSON-RPC command and the DBus Group.terminateGroup method
FailSpy
force-pushed
the
feature/groupv2-terminate
branch
from
August 8, 2026 15:03
db847f1 to
1ba6595
Compare
AsamK
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signal recently added the ability for a group admin to permanently terminate a group ("End group" in the app UI): once it's terminated the group is read-only for everyone -- nobody, admins included, can send messages or start calls -- and members keep the existing history. Other clients silently drop any message sent to a terminated group. The pinned
signal-networkalready carries the protobuf for it (DecryptedGroup.terminated, plus theTerminateGroupActionchange), so signal-cli just wasn't reading or offering it yet. This wires it up both directions.Seeing that a group is terminated
Today signal-cli can't tell a terminated group from a live one, and it'll report a sent message as
SUCCESSeven though every other client drops it. This readsDecryptedGroup.terminatedthroughGroupInfo.isTerminated()and:listGroups(JSON, and both the default and--detailedplaintext lines) and as the DBusIsTerminatedpropertyisNotAllowedToSendToGroup, alongside the announcement-group handling)The send refusal mirrors the existing
isAnnouncementGroupwiring, with one difference: it's unconditional. Announcement-only exempts admins; a terminated group blocks everyone.On the
listGroupsoutput: I putTerminatedon the default (non-detailed) line, right afterBlocked.Blockedis almost always false yet already lives there, so that line is a status-at-a-glance row, not an only-show-non-defaults one. Terminated is a peer ofBlocked-- both mean "this isn't a usable conversation" -- and since a terminated group otherwise looks completely normal, the glanceable line is where it's most worth surfacing. Happy to move it behind--detailedif you'd rather leave the default line untouched.Terminating a group
Adds a
terminateGroupcommand (admin-only, v2 groups) that sends theTerminateGroupActionvia the library's owncreateTerminateGroup()and notifies the members. It follows thequitGroupshape end to end --GroupHelper.terminateGroup->Manager/ManagerImpl-> theterminateGroupcommand (command line + JSON-RPC) and the DBusGroup.terminateGroupmethod -- with the same conflict-retry asupdateGroup.Tests / scope
Added a unit test for the terminated model reads and the
Grouprecord wiring, in the existing JUnit style (no new deps). The send-path guards aren't unit-covered -- there's no existing test path for the outgoing/send layer to build on -- but theisTerminated()signal they rely on is.