Skip to content

Don't limit admin log requests #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WouterKoch wants to merge 2 commits into from
Closed

Don't limit admin log requests #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01c9e13
Don't limit admin log requests
WouterKoch Apr 2, 2026
0a00128
Set a (high) rate limit for admin log tasks
WouterKoch Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion middleware/rateLimiters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,24 @@ const authLimiter = rateLimit({
},
});

const adminLimiter = rateLimit({
windowMs: 1 * 60 * 1000,
max: 250,
standardHeaders: true,
legacyHeaders: false,
keyGenerator: ipKey,
handler: (request, response, next, options) => {
writeErrorLog(
`Too many admin requests`,
`IP ${getClientIP(request)}`
);
return response.status(options.statusCode).send(options.message);
},
});

module.exports = {
idLimiter,
apiLimiter,
authLimiter
authLimiter,
adminLimiter
};
6 changes: 3 additions & 3 deletions routes/admin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const fs = require("fs");
const path = require("path");
const { apiLimiter, authLimiter } = require("../middleware/rateLimiters");
const { authLimiter, adminLimiter } = require("../middleware/rateLimiters");
const {
authenticateAdminToken,
getValidTokens,
Expand Down Expand Up @@ -268,7 +268,7 @@ module.exports = (app, upload) => {
}
});

app.get("/admin/logs", authLimiter, authenticateAdminToken, (req, res) => {
app.get("/admin/logs", adminLimiter, authenticateAdminToken, (req, res) => {
try {
var json = [];
fs.readdir(logdir, function (err, files) {
Expand All @@ -287,7 +287,7 @@ module.exports = (app, upload) => {
}
});

app.get("/admin/logs/*splat", authLimiter, authenticateAdminToken, (req, res) => {
app.get("/admin/logs/*splat", adminLimiter, authenticateAdminToken, (req, res) => {
try {
let filename = decodeURI(req.originalUrl.replace("/admin/logs/", ""));
const resolvedPath = path.resolve(logdir, filename);
Expand Down
Loading