fix(footer): resolve Accessibility/Privacy links at any base path - #31
Open
rancur wants to merge 1 commit into
Open
fix(footer): resolve Accessibility/Privacy links at any base path#31rancur wants to merge 1 commit into
rancur wants to merge 1 commit into
Conversation
The footer links were hardcoded as "/accessibility.html" and "/privacy.html". Those resolve on azmsh.net but 404 on any build served from a sub-path, so the a11y/privacy pages added in ArizonaMeshtasticCommunity#25 are unreachable in PR preview builds. Move them out of the `copyright:` string into an override of Material's copyright partial, which builds them from {{ base_url }} so they resolve at every page depth and under any base path. Also relativize the five internal links in Recommended Hardware and the WisMesh build guide that use absolute /docs/*.html paths, for the same reason. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018pAXdnH4iJEpsWMTYy9hhn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Accessibility and Privacy links added in #25 are hardcoded as
/accessibility.htmland/privacy.html. Those resolve on azmsh.net but 404 onany build served from a sub-path, which is every PR preview — so the two pages
that exist specifically for accessibility compliance are the two you can't reach
when reviewing a change.
Moved out of the
copyright:string into an override of Material's copyrightpartial, which builds them from
{{ base_url }}. Also relativized the four/docs/wismesh-repeater-mini-1w.htmllinks in Recommended Hardware, which havethe same problem.
What to look at: the footer of any page on the preview, then the same page on
the before build — the links
404 there.
Not in this PR: links whose target pages move in PRs 6 and 7.
Preview: https://rancur.github.io/azmsh-site/preview/split-01-footer-links/